fix(host): add wss: to CSP connect-src for plugin WebSocket support - #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
wss:scheme to the CSPconnect-srcdirective in the host security middleware, alongside the existinghttps:scheme-wide allowance.Context
Plugins that need WebSocket connections (e.g. nostr relays, streaming APIs) were failing through the host because the CSP
connect-srcdirective didn't includewss:. While plugins can declareconnectSrcin their config, the CSP middleware is built once at boot time from the base config — tenant-specificconnectSrcvalues never reached the response headers.Adding
wss:scheme-wide is consistent with the existinghttps:permissiveness in the same directive, and immediately unblocks all WebSocket connections without requiring a per-request CSP refactor.Changes
host/src/middleware/security.ts: Added"wss:"toconnectSrcarray.changeset/wild-ghosts-brake.md: ChangesetTesting
bun typecheck— passesbun lint— passes