fix: extract renderClientShell, fix e2e test failures - #233
Merged
Conversation
- host: extract security middleware (cors/csrf/rate-limit/csp), static asset proxy, and API oRPC route setup out of program.ts into dedicated modules composed via SecurityMiddleware Live layer - host: emit site.webmanifest manifest link in renderClientShell and fix runtime-remote test to assert it (drop stale BOS iframe assertion) - host: dedupe normalizeDomain/normalizeUrl/extractErrorDetails into utils, remove inline duplicates from program/plugins/tenant-runtime - api: add vitest config, HTTP integration harness with typed oRPC clients and injectable auth/org context, integration tests for ping/ authHealth/resolveTenant/preflight/testError, and PGlite unit tests for TenantsService; fixes 'no test files found' in test:api
- Extract renderClientShell from program.ts into host/src/routes/html.ts
(nonce now passed as param instead of recomputing CSP_STRICT)
- Fix stale theme toggle locator: 'Toggle theme' -> 'Switch to ... theme'
- Fix proxy target json-proxy-target.ts:
- Return oRPC-compatible RPC format { json, meta } for /api/rpc/*
- Add stubs for /api/auth/get-session and /api/auth/near/list-accounts
- Fix 18 host vitest failures: provide mock session in test render options
- Replace stale assertion in ssr-bundled-runtime test
- Document bun run --cwd host test in AGENTS.md
…ilder from program.ts - Inline proxyUiAssetRequest at its single call site - Extract buildRuntimeClientConfig, resolveActiveRuntime, getFallbackGatewayId to services/config.ts - Extract static asset proxy middleware (lines 198-222) to middleware/static-proxy.ts as createStaticAssetProxyHandler() - Extract SSR fallback handler (lines 226-298) to routes/ssr.ts as createSsrFallbackHandler() - Remove unused imports from program.ts - buildRuntimeClientConfig now takes authAvailable: boolean instead of plugins: PluginResult to avoid circular dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract
renderClientShellfromprogram.tsintohost/src/routes/html.tsand fix test suite.Changes:
renderClientShelltohost/src/routes/html.ts— nonce passed as param instead of recomputingCSP_STRICT'Toggle theme'→/Switch to .* theme/json-proxy-target.ts):{ json, meta }for/api/rpc/*/api/auth/get-sessionand/api/auth/near/list-accountsbun run --cwd host testin AGENTS.mdVerification: