Skip to content

fix proxy-state parser #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KotikovAlexander wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix proxy-state parser #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6aa9cca
fix proxy-state parser
Jul 31, 2026
38b7e1f
add array and long attributes parser
Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions ...Radius.Adapter.v2.Infrastructure/Features/PacketHandler/Adapters/AdapterResponseSender.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,14 +176,27 @@ private static void CopyAttributes(RadiusPacket? source, RadiusPacket? target)

private void AddProxyStateAttribute(RadiusPacket source, RadiusPacket target)
{
if (!source.Attributes.TryGetValue(ProxyStateAttribute, out var proxyStateAttribute)) return;
if (target.Attributes.ContainsKey(ProxyStateAttribute)) return;
var value = proxyStateAttribute.Values.FirstOrDefault();
if (value != null)
if (!source.Attributes.TryGetValue(ProxyStateAttribute, out var proxyStateAttribute))
{

_logger.LogDebug("Source Attribute '{attrname:l}' is empty", ProxyStateAttribute);
return;
}
if (target.Attributes.ContainsKey(ProxyStateAttribute))
{
_logger.LogDebug("Target already contains attribute '{attrname:l}'", ProxyStateAttribute);
return;
}
var value = proxyStateAttribute.Values;
if (value is { Count: > 0 })
{
_logger.LogDebug("Added/replaced attribute '{attrname:l}' to reply", ProxyStateAttribute);
target.AddAttributeValue(ProxyStateAttribute, value);
}
else
{
_logger.LogDebug("Attribute '{attrname:l}' is empty", ProxyStateAttribute);
}
}

private static void AddMessageAuthenticatorIfMissing(RadiusPacket packet)
Expand Down
13 changes: 13 additions & 0 deletions ...s.Adapter.v2.Infrastructure/Features/PacketHandler/Adapters/Radius/RadiusPacketBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System.Collections;
using System.Net;
using System.Text;
using Multifactor.Radius.Adapter.v2.Application.Core.Enum;
Expand Down Expand Up @@ -210,10 +211,22 @@ private static byte[] GetAttributeValueBytes(object value)
contentBytes = BitConverter.GetBytes(val);
Array.Reverse(contentBytes);
return contentBytes;
case long val:
contentBytes = BitConverter.GetBytes(val);
Array.Reverse(contentBytes);
return contentBytes;
case ulong val:
contentBytes = BitConverter.GetBytes(val);
Array.Reverse(contentBytes);
return contentBytes;
case byte[] val:
return val;
case IPAddress val:
return val.GetAddressBytes();
case IEnumerable val:
return val.Cast<object>()
.SelectMany(GetAttributeValueBytes)
.ToArray();
default:
throw new NotImplementedException();
}
Expand Down