Skip to content

Add Run 2 CRV SurfaceIds and update CRVModule material definition#1858

Open
RobMina wants to merge 3 commits into
Mu2e:mainfrom
RobMina:crv-run2-surfaceids-src
Open

Add Run 2 CRV SurfaceIds and update CRVModule material definition#1858
RobMina wants to merge 3 commits into
Mu2e:mainfrom
RobMina:crv-run2-surfaceids-src

Conversation

@RobMina

@RobMina RobMina commented Jun 12, 2026

Copy link
Copy Markdown

Run 2 CRV sector IDs and material definition from Mu2eG4/geom/crv_counters_v10.txt

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @RobMina,
You have proposed changes to files in these packages:

  • TrackerConditions
  • DataProducts

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

📝 The author of this pull request is not a member of the Mu2e github organisation.

About FNALbuild. Code review on Mu2e/Offline.

@brownd1978 brownd1978 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few minor changes requested.

Comment thread DataProducts/inc/SurfaceId.hh Outdated
@RobMina RobMina requested a review from brownd1978 June 12, 2026 20:51
# CRV active module stack from crv_parameters.xlsx (DocDB 862 https://mu2e-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=862):
# 4 scintillator layers (4*19.80 mm) + 3 aluminum absorbers (3*9.525 mm)
# + aluminum strongback (12.7 mm) + thin aluminum cover (3.175 mm),
# represented as one effective material without the inter-layer air gaps.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The air gaps don't matter in terms of material, but the density of the composite needs to be compatible with the thickness ascribed to a module, currently set here. Can you please check these are consistent?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scaled the density up to match the half-width from the KinKalGeomMaker code. While testing I discovered that the half-width of the U/D sectors was negative:

CRV sector CRV_R2 midpoint (-2581.19,275.53,-2871.1) wdir (-1,0,0) udir (0,1,0) vdir (0,0,-1) uhw 2275 vhw 5433.42 whw 53.8875
CRV sector CRV_D1 midpoint (0,1761.5,8457.26) wdir (0,0,1) udir (1,0,0) vdir (0,1,0) uhw 2850 vhw 1237.92 whw -34.0875
CRV sector CRV_U midpoint (650,1599.75,-12526.8) wdir (0,0,-1) udir (1,0,0) vdir (0,-1,0) uhw 3450 vhw 1651.17 whw -34.0875

Added a std::abs around that so half-widths are consistently 53.8875 mm.

…lso fix sign error in half-width calculation for CRV U and D sectors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants