Stm unpacking#1857
Open
Etho-b02 wants to merge 5 commits into
Open
Conversation
Collaborator
|
Hi @Etho-b02,
which require these tests: build. @Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main. 📝 The author of this pull request is not a member of the Mu2e github organisation. |
AndrewEdmonds11
approved these changes
Jun 12, 2026
AndrewEdmonds11
left a comment
AndrewEdmonds11
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thanks, Bryan. A couple of small comments below
Comment on lines
12
to
22
| @@ -19,6 +20,22 @@ namespace mu2e { | |||
| // Look at last four characeters of module label to decide channel | |||
| return STMChannel(STMChannel::findByName(label.substr(label.length()-4,4))); | |||
| } | |||
Contributor
There was a problem hiding this comment.
You can just remove this commented out block. We can always go back in the history to find it again
| if (name.empty()){ | ||
| name = tag.label(); | ||
| } | ||
| if (name.find("HPGe") != std::string::npos){ |
Contributor
There was a problem hiding this comment.
Maybe we also want to make this case insensitive?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned Up the if statement in line 187 in STMMovingWindowDeconvolution_module.cc.
Fixed instance-name mismatch in modules.
Cleared up getChannel in plotSTMWaveformDigis_module.cc
Also cleaned up last comment in inspectSTMFile.fcl.
Added STMFragmentSummary to collect container and inner frag counts from unpacking module.
Addressed fragment count issues from last PR.