Skip to content

feat(hooks): expose session_dir and inject SessionStart hook output into main agent context#847

Open
AzazelSensei wants to merge 3 commits into
MoonshotAI:mainfrom
AzazelSensei:feat/persistent-memory-hooks
Open

feat(hooks): expose session_dir and inject SessionStart hook output into main agent context#847
AzazelSensei wants to merge 3 commits into
MoonshotAI:mainfrom
AzazelSensei:feat/persistent-memory-hooks

Conversation

@AzazelSensei

Copy link
Copy Markdown

This PR enables external persistent-memory hooks for Kimi Code CLI by:

  • Adding session_dir to every hook payload so hooks can locate the session wire log.
  • Consuming SessionStart hook results and appending non-empty stdout/message text to the main agent context, matching the hook contract used by Claude/Codex.

Motivation: third-party memory layers need to inject a recall block at session start and know where the transcript lives.

Tests: npm_config_engine_strict=false pnpm --filter @moonshot-ai/agent-core test → 2605 passed.

…n payload

- Append non-empty SessionStart hook stdout/message to the main agent
  context as a hook_result message, mirroring UserPromptSubmit behavior.
- Add session_dir to the base hook payload so external integrations can
  locate session artifacts (e.g. wire.jsonl).
@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 59edaa3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@moonshot-ai/kimi-code-sdk Minor
@moonshot-ai/kimi-code Minor
@moonshot-ai/acp-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74ba296e87

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/agent-core/src/session/index.ts
Comment thread docs/en/customization/hooks.md Outdated
Comment thread docs/en/customization/hooks.md
- Skip timed-out / non-zero-exit SessionStart hook results before
  injecting their output into the main agent context (mirrors the
  UserPromptSubmit path), so partial/error output isn't treated as recall data.
- Mark SessionStart as non-blocking in the hooks reference; it injects
  context but cannot block startup.
- Mirror the session_dir payload field and the updated SessionStart
  description into the zh docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant