rfc: add RFC 0039, the end-to-end benchmark - #535
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Want your agent to iterate on Greptile's feedback? Start a greploop in Claude Code and it will work through the open comments and keep going until this PR reviews clean. |
5 tasks
aaltshuler
force-pushed
the
rfc-benchmark-design
branch
from
August 20, 2026 14:06
9b1e482 to
e0e6a12
Compare
aaltshuler
force-pushed
the
rfc-benchmark-design
branch
from
August 20, 2026 14:12
e0e6a12 to
66bc885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Omnigraph's measurement foundation is taking shape: the DST counting golden and the calibrated real-backend ceilings (originated in PR #503 and absorbed into the in-flight contributions) are arriving under RFC-031 and its in-flight amendment. Once they land, storage-call counting is covered end to end. The natural next step is wall-clock performance: how fast, at what throughput, at what cost, with what answer quality. No specification for that exists yet, and this RFC provides it: the end-to-end benchmark, and the rules a published number must satisfy so it is reproducible and defensible.
The core of the proposal, in plain terms: every benchmark run is fully described by its parameters (what data is stored, what state the store is in, what the run does, where it runs, how it is measured), that description plus the results is persisted as an immutable run record which every published number must cite, and seven protocol rules make dishonest or irreproducible numbers invalid rather than merely sloppy (examples: latency claims must come from a driver that cannot hide the worst latencies, wall-clock numbers only from release builds, no bare averages, every number names its backend and machine, effects below the measured noise floor read "no detected effect"). One instrument covers both micro-benchmarking (single operations, per-phase timing, to find where time goes) and realistic workloads (what users feel), as two named configurations of the same harness.
The design is derived from the published record of two benchmark traditions (LDBC / DBTest for databases, the LoCoMo scoring disputes for agent-memory systems); the Motivation section carries the citations. It builds on RFC-031 and changes nothing RFC-031 owns.
Backing issue / RFC
needs-rfc):docs/rfcs/0039-end-to-end-benchmark.mdChecklist
Local verification
bash scripts/check-agents-md.sh— passedgit diff --check— passedNotes for reviewers
Greptile Summary
RFC 0039 specifies a reproducible end-to-end benchmarking instrument spanning wall-clock performance, storage calls, throughput, quality, and cost.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR S[Run specification] --> F[Validated frozen fixture] S --> W[Workload and conditions] F --> H[Shared benchmark harness] W --> H H --> M[Measurements] M --> R[Invocation-keyed run record] R --> P[Published number citing record] H --> C[Layer-specific reconciliation] C --> RReviews (10): Last reviewed commit: "docs(rfc): key calibration by layer voca..." | Re-trigger Greptile