docs(rfc): amend adversarial harness with the DST execution layer - #526
docs(rfc): amend adversarial harness with the DST execution layer#526azimafroozeh wants to merge 1 commit into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
| (the mock-time ask, evidenced by the counting golden's byte wobble | ||
| recorded in RFC-031 §11), with entropy and scheduling seams as |
There was a problem hiding this comment.
RFC-031 evidence citation is broken
When readers follow this citation to validate the injectable-clock rationale, RFC-031 ends at §10 and contains neither the counting-golden nor byte-wobble evidence, leaving the amendment's stated evidence source unusable.
Context Used: CLAUDE.md (source)
| world; its design document is the deterministic simulation RFC (PR #507, in | ||
| review). That RFC's unresolved question 1 asked whether it should amend this | ||
| RFC in place or stand beside it; this amendment is the in-place half of the | ||
| answer. Details live in the simulation RFC; this amendment cites, it does | ||
| not restate. |
There was a problem hiding this comment.
The amendment explains its durable rationale through “PR #507, in review” and that PR's “unresolved question 1.” Once the review concludes, this wording becomes stale and forces readers to reconstruct historical review state instead of stating the design decision directly.
Context Used: AGENTS.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
What & why
This PR amends RFC-032 in place: a new §13 records the deterministic execution layer beneath the harness, and nothing in §§1-12 is restructured.
Local verification
docs/rfcs/0032-adversarial-correctness-harness.md; cargo gates not run: no code touchedbash scripts/check-agents-md.sh: 77 links, 72 docs OKGreptile Summary
This documentation-only PR amends RFC-032 to describe how its adversarial instruments relate to the deterministic simulation execution layer.
Confidence Score: 4/5
The PR should not merge until the nonexistent RFC-031 §11 citation is corrected; the transient review-state wording is otherwise non-blocking.
The amendment presents a specific measurement as recorded in RFC-031 §11, but RFC-031 ends at §10 and contains no such evidence, leaving a central design rationale unverifiable.
Files Needing Attention: docs/rfcs/0032-adversarial-correctness-harness.md
Important Files Changed
Reviews (1): Last reviewed commit: "imp" | Re-trigger Greptile
Context used: