docs(rfc): align RFC-033 with recovery and runtime ownership - #520
Open
aaltshuler wants to merge 1 commit into
Open
docs(rfc): align RFC-033 with recovery and runtime ownership#520aaltshuler wants to merge 1 commit into
aaltshuler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Align RFC-033’s remaining Blob work with the recovery, served-operation ownership, and runtime-activation boundaries defined by RFC-034, RFC-035, and RFC-036.
The update keeps Blob
put/clearon the ordinary Mutation path, makes served reads and writes follow the same exact-generation and lifetime rules as other operations, and assigns recovery/supervision to the canonical shared architecture. It also makes the implementation sequence and remaining acceptance work explicit.This is documentation-only: it changes no code, wire API, storage format, or currently implemented Blob read behavior.
Backing issue / RFC
Checklist
docs/dev/invariants.md— no Hard Invariant weakened, no deny-list item hitLocal verification
cargo test -p omnigraph-engine --locked --test end_to_end blob_ -- --nocapture— 14 passedRUST_MIN_STACK=16777216 cargo test -p omnigraph-engine --locked --test branching blob_ -- --nocapture— 4 passedcargo test -p omnigraph-engine --locked --test lance_surface_guards compact_files_succeeds_on_blob_columns -- --exact --nocapture— 1 passedcargo test -p omnigraph-engine --locked --test maintenance optimize_compacts_blob_table_alongside_plain_table -- --exact --nocapture— 1 passedRUST_MIN_STACK=16777216 cargo test -p omnigraph-server --locked --test data_routes blob_ -- --nocapture— 4 passedRUST_MIN_STACK=16777216 cargo test -p omnigraph-server --locked --test openapi openapi_blob -- --nocapture— 2 passedscripts/check-agents-md.sh— passedgit diff --check— passedNotes for reviewers
This PR records architectural dependencies and implementation order; it does not mark RFC-034–036 implemented. Phase 0–2B behavior remains unchanged. The future implementation still owns server failpoint/cancellation coverage and the Blob cleanup acceptance case.
Greptile Summary
RFC-033 is aligned with the recovery, served-operation ownership, and runtime-generation contracts established by RFC-034 through RFC-036.
Confidence Score: 5/5
This documentation-only PR appears safe to merge.
The revised engine, HTTP, CLI, recovery, runtime-lifecycle, error, and acceptance-test contracts are internally consistent and align with the referenced architecture RFCs.
Important Files Changed
Reviews (1): Last reviewed commit: "docs(rfc): align RFC-033 with recovery a..." | Re-trigger Greptile