Skip to content

docs(rfc): align RFC-033 with recovery and runtime ownership - #520

Open
aaltshuler wants to merge 1 commit into
mainfrom
codex/align-blob-rfc-runtime
Open

docs(rfc): align RFC-033 with recovery and runtime ownership#520
aaltshuler wants to merge 1 commit into
mainfrom
codex/align-blob-rfc-runtime

Conversation

@aaltshuler

@aaltshuler aaltshuler commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

What & why

Align RFC-033’s remaining Blob work with the recovery, served-operation ownership, and runtime-activation boundaries defined by RFC-034, RFC-035, and RFC-036.

The update keeps Blob put/clear on the ordinary Mutation path, makes served reads and writes follow the same exact-generation and lifetime rules as other operations, and assigns recovery/supervision to the canonical shared architecture. It also makes the implementation sequence and remaining acceptance work explicit.

This is documentation-only: it changes no code, wire API, storage format, or currently implemented Blob read behavior.

Backing issue / RFC

  • Fixes an accepted issue: Closes #
  • Is an RFC PR, or implements a merged RFC: RFC-033
  • Trivial fast-lane (typo / docs / dependency bump / comment / one-line CI) — no issue/RFC required

Checklist

  • Change is focused (one logical change)
  • Tests added/updated for behavior changes (or N/A) — architecture-doc-only alignment; existing Blob regression baseline audited
  • Public docs updated if user-facing surface changed (or N/A) — no shipped behavior changed
  • Reviewed against docs/dev/invariants.md — no Hard Invariant weakened, no deny-list item hit

Local verification

  • cargo test -p omnigraph-engine --locked --test end_to_end blob_ -- --nocapture — 14 passed
  • RUST_MIN_STACK=16777216 cargo test -p omnigraph-engine --locked --test branching blob_ -- --nocapture — 4 passed
  • cargo test -p omnigraph-engine --locked --test lance_surface_guards compact_files_succeeds_on_blob_columns -- --exact --nocapture — 1 passed
  • cargo test -p omnigraph-engine --locked --test maintenance optimize_compacts_blob_table_alongside_plain_table -- --exact --nocapture — 1 passed
  • RUST_MIN_STACK=16777216 cargo test -p omnigraph-server --locked --test data_routes blob_ -- --nocapture — 4 passed
  • RUST_MIN_STACK=16777216 cargo test -p omnigraph-server --locked --test openapi openapi_blob -- --nocapture — 2 passed
  • scripts/check-agents-md.sh — passed
  • git diff --check — passed

Notes for reviewers

This PR records architectural dependencies and implementation order; it does not mark RFC-034–036 implemented. Phase 0–2B behavior remains unchanged. The future implementation still owns server failpoint/cancellation coverage and the Blob cleanup acceptance case.

Greptile Summary

RFC-033 is aligned with the recovery, served-operation ownership, and runtime-generation contracts established by RFC-034 through RFC-036.

  • Keeps Blob replacement and clear on the shared Mutation publication and recovery path.
  • Defines exact commit receipts and same-publication Blob outcomes for writes.
  • Pins served reads and writes to one runtime generation with the appropriate lifecycle ownership.
  • Clarifies implementation ordering, error mappings, CLI/HTTP parity, and remaining acceptance work.

Confidence Score: 5/5

This documentation-only PR appears safe to merge.

The revised engine, HTTP, CLI, recovery, runtime-lifecycle, error, and acceptance-test contracts are internally consistent and align with the referenced architecture RFCs.

Important Files Changed

Filename Overview
docs/rfcs/0033-blob-management.md The normative Blob design is consistently updated for shared recovery authority, exact-generation operation ownership, exact write receipts, and implementation sequencing; no actionable inconsistency was found.

Reviews (1): Last reviewed commit: "docs(rfc): align RFC-033 with recovery a..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant