improve semantics for rule_priority#79
Draft
skalexch wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify the wording of
rule_priorityin order to:rule_priorityvalue as 0 only when the field exists in the header.Describe the Problem
Elaborated on further in google#575, the semantics of
rule_prioritycan be vague and might cause interpretation issues. The existence of the field affects matching fare leg predicates.Therefore, any misinterpretation of the existence of the field vs the value affects the interpretation of an empty predicate (e.g. an empty
network_idis interpreted differently based on the existence of the COLUMNrule_priority.Use Cases
Proposed Solution
Clarify the spec by:
rule_priorityfield exists" to "therule_priorityfield is defined in the table header", and doing the same for the negative version of that sentence.rule_priorityis treated as zero." to "If therule_priorityfield is defined in the header, an empty value forrule_priorityis treated as zero."Type of change
GTFS Schedule
GTFS Realtime
Additional Information
Proposed Discussion Period
Testing Details
Proposal Update Tracker
Checklist