Skip to content

feat: 当自动更新失败时下次再次打开弹窗提示#282

Open
zmdyy0318 wants to merge 1 commit into
MistEO:mainfrom
zmdyy0318:feat/2026071401
Open

feat: 当自动更新失败时下次再次打开弹窗提示#282
zmdyy0318 wants to merge 1 commit into
MistEO:mainfrom
zmdyy0318:feat/2026071401

Conversation

@zmdyy0318

@zmdyy0318 zmdyy0318 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

避免用户不知道怎么弄,打开软件后一片空白
close MaaEnd/MaaEnd#4167
opus4.8

image

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我在下面给出了一些高层面的反馈:

  • FallbackRecoveryModal.handleDone 中,当你清除 pending 标志时,建议同时调用 setFallbackRecoveryInfo(null),这样可以保证在模态框被隐藏时,store 的状态依然保持一致,并且不会在内存中保留过期的 fallback 信息。
  • 当将 FallbackPendingInfo 持久化到 localStorage 时,你可能需要在 getFallbackPendingInfo 中加入一个简单的版本/结构(schema)字段或时间检查,这样非常旧或不兼容的 fallback 标记就会被自动忽略,而不是在较长时间间隔后或未来结构变更时仍然反复打扰用户。
给 AI Agent 的提示
Please address the comments from this code review:

## Overall Comments
- In `FallbackRecoveryModal.handleDone`, consider also calling `setFallbackRecoveryInfo(null)` when you clear the pending flag so the store state stays consistent with the hidden modal and you don't retain stale fallback info in memory.
- When persisting `FallbackPendingInfo` to `localStorage`, you might want to include a simple version/schema field or age check in `getFallbackPendingInfo` so that very old or incompatible fallback markers are automatically ignored instead of repeatedly prompting users after long intervals or future schema changes.

Sourcery 对开源项目是免费的——如果你觉得我们的评审有帮助,请考虑分享给更多人 ✨
帮我变得更有用!请在每条评论上点击 👍 或 👎,我会根据你的反馈不断改进评审质量。
Original comment in English

Hey - I've left some high level feedback:

  • In FallbackRecoveryModal.handleDone, consider also calling setFallbackRecoveryInfo(null) when you clear the pending flag so the store state stays consistent with the hidden modal and you don't retain stale fallback info in memory.
  • When persisting FallbackPendingInfo to localStorage, you might want to include a simple version/schema field or age check in getFallbackPendingInfo so that very old or incompatible fallback markers are automatically ignored instead of repeatedly prompting users after long intervals or future schema changes.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `FallbackRecoveryModal.handleDone`, consider also calling `setFallbackRecoveryInfo(null)` when you clear the pending flag so the store state stays consistent with the hidden modal and you don't retain stale fallback info in memory.
- When persisting `FallbackPendingInfo` to `localStorage`, you might want to include a simple version/schema field or age check in `getFallbackPendingInfo` so that very old or incompatible fallback markers are automatically ignored instead of repeatedly prompting users after long intervals or future schema changes.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@zmdyy0318 zmdyy0318 changed the title feat: 当自动更新未完成时下次再次打开mxu提示手动从兜底文件夹覆盖更新 feat: 当自动更新失败时下次再次打开mxu提示手动从兜底文件夹覆盖更新 Jul 15, 2026
@zmdyy0318 zmdyy0318 changed the title feat: 当自动更新失败时下次再次打开mxu提示手动从兜底文件夹覆盖更新 feat: 当自动更新失败时下次再次打开弹窗提示 Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.19.0版本更新后功能缺失异常

1 participant