[codex] add macOS controller support#271
Draft
a16797 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MacOScontroller typeController::new_macosCloses #242
Adversarial review notes
maa-framework 1.16.0docs exposeController::new_macos(window_id, screencap_method, input_method)Validation
npm run build(tsc && vite build) passedgit diff --checkpassedNot verified
cargo/rustcSummary by Sourcery
为现有桌面控制器新增一流的 macOS 原生窗口控制器支持,并通过共享的连接/选择流程进行路由。
New Features:
Controller::new_macos连接 MaaFramework 的 macOS 控制器。Enhancements:
Original summary in English
Summary by Sourcery
Add first-class macOS native window controller support alongside existing desktop controllers and route it through the shared connection/selection flows.
New Features:
Enhancements: