GEOPY-2848: Create issues for actionable TODOs and remove comments.#207
Open
benk-mira wants to merge 3 commits into
Open
GEOPY-2848: Create issues for actionable TODOs and remove comments.#207benk-mira wants to merge 3 commits into
benk-mira wants to merge 3 commits into
Conversation
…pp to include driver switchover
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Removes several actionable TODO/deprecation comments across the runtime/driver parameter code, aligning the codebase with the “create issues, remove TODOs from code” cleanup objective.
Changes:
- Removed deprecated/actionable TODO comments from
run.py,driver/params.py, andbase.py. - Added a
# type: ignoreto theInputFile.validationsassignment inBaseParams.input_file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| geoapps_utils/run.py | Removes a deprecation-related TODO near driver import logic. |
| geoapps_utils/driver/params.py | Removes a TODO note in free_parameter_dict and adds a typing suppression on validations assignment. |
| geoapps_utils/base.py | Removes an outdated TODO from the Driver docstring area. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
439
to
+441
| if ifile is not None: | ||
| self.validator = ifile.validators | ||
| self.validations = ifile.validations | ||
| self.validations = ifile.validations # type: ignore |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #207 +/- ##
========================================
Coverage 85.95% 85.95%
========================================
Files 19 19
Lines 1196 1196
Branches 155 155
========================================
Hits 1028 1028
Misses 127 127
Partials 41 41
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2848 - Create issues for actionable TODOs and remove comments.