Revise IP assignment and DNS setup instructions#4338
Conversation
Updated the deployment guide to reflect feature available to 2607 release. Changes are in IP assignment options and DNS service setup for Azure Local
|
@andyk-ms : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 9116160: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Hi @andyk-ms - This pull request was opened in the public repo. Microsoft contributors should work in the private repo, per the Microsoft Docs contributor guide. We can keep this PR open for review and merge, but would you make future content updates in the private repo? Thank you! Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
Bot
added
the
aq-pr-triaged
There was a problem hiding this comment.
⚠️ Not ready to approve
The updated prerequisites introduce multiple clarity/grammar issues (including a broken option string) and the moniker gating is inconsistent with the fallback moniker block later in the file.
Pull request overview
This PR updates the Azure Local deployment guide for “local identity with Azure Key Vault” to reflect functionality available starting in the azloc-2607 release, primarily around IP assignment and DNS setup guidance.
Changes:
- Updated the document’s moniker gating to start at
>=azloc-2607. - Replaced the previous static-IP-only prerequisite with new “Manual vs Automatic (DHCP)” IP assignment guidance.
- Expanded prerequisites to describe two DNS service setup paths (existing DNS vs internal infrastructure-only DNS).
File summaries
| File | Description |
|---|---|
| azure-local/deploy/deployment-local-identity-with-key-vault.md | Updates version gating and revises prerequisites to describe IP assignment and DNS service setup options for azloc-2607. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 4
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Note: After the OS is installed, it is defaulted to DHCP, and if a DHCP server is available and support IP reservation, no change is needed. For static IP address, use SConfig to set the static IP address, subnet, gateway, and DNS (See DNS Service Setup). | ||
|
|
| - DNS Service setup supports 2 options: | ||
| - Existing DNS Service - "Yes" : If there is an existing DNS servers, the IP address and the corresponding server/cluster hostname must be added to the DNS server under a specific DNS zone. And this DNS Server IP should be setup within Nodes and Instance IP assignments in the DNS IP field. Here is an example DNS setup that can support Azure Local Deployment - See [Configure DNS server for Azure Local](#configure-dns-server-for-azure-local). | ||
| - Existing DNS Service - "No" : If there is no existing DNS servers, and no plan to have an external DNS to manage the cluster hostname resolution, this option will configure an internal infrastructure only DNS for the cluster. It will require an DNS forwarder, such as an IP gateway or public DNS server for internet endpoint resolution. (Note: this internal DNS do not support external application uses and it is intended for cluster internal infrastructure operations only). |
| # Deploy Azure Local using local identity with Azure Key Vault | ||
|
|
||
| ::: moniker range=">=azloc-2510" | ||
| ::: moniker range=">=azloc-2607" |
|
based on comment, re-create this PR on the private repo: |
Updated the deployment guide to reflect feature available to 2607 release. Changes are in IP assignment options and DNS service setup for Azure Local