Release: Delete api-test.yml and update CI/CD pipeline - #9
Merged
Conversation
…Release-> merge all the devs update and run CI and check API Testing, Main-> run CI and CD. . and Upload Shihab API Testing File
There was a problem hiding this comment.
Pull request overview
This PR consolidates API test execution into the main CI/CD workflow and removes the now-redundant dedicated API test workflow, aiming to simplify the pipeline and keep tests as a prerequisite for deployments.
Changes:
- Expanded the CI/CD workflow trigger branches and renamed the workflow for clarity.
- Added a dedicated
testjob that runs Newman against Postman collections and madedeploydepend on it. - Deleted the separate API test workflow file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/ci-cd.yml |
Adds a Newman-based API test job and gates deployment on tests; updates workflow naming and branch triggers. |
.github/workflows/api-tests.yml |
Removes the standalone API test workflow in favor of the consolidated pipeline. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+23
to
+28
| - name: Run all Postman collections | ||
| run: | | ||
| for file in collections/*.json; do | ||
| echo "Running $file" | ||
| newman run "$file" | ||
| done |
| @@ -1,12 +1,37 @@ | |||
| name: Initial CI/CD Pipeline | |||
| name: CI/CD Pipeline (Test & Deploy) | |||
Comment on lines
+30
to
+34
| deploy: | ||
| name: Build & Deploy to Azure | ||
| runs-on: ubuntu-latest | ||
| needs: test | ||
| if: github.ref == 'refs/heads/main' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.