Fix PlayerRadarHud null crash when switching servers#6455
Open
Frko5000 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
PlayerRadarHud was crashing when switching servers on a hub network. During a server switch, Minecraft starts clearing the current world and entities become null. The HUD was still rendering and trying to call .position() on null entities, causing a NullPointerException. Fixed by adding a null check to filter out null entities and a null camera entity before sorting.
Related issues
Fixes #6433
How Has This Been Tested?
Tested by switching servers on a hub network with PlayerRadarHud enabled. The crash no longer occurs.
Checklist: