Refactor/ci-and-browser-tx-building-alignment#256
Merged
Andre-Diamond merged 9 commits intoMay 29, 2026
Conversation
Collaborator
Andre-Diamond
commented
May 20, 2026
Andre-Diamond
commented
- Added a new test command for TRPC in package.json to facilitate targeted testing of TRPC-related components.
- Updated the unit test workflow to correct the test path pattern for transaction builder tests, ensuring accurate test execution.
- Removed unused cborUtils.ts file to clean up the test directory and improve maintainability.
- Simplified infrastructure tests by removing unnecessary cbor-x decoding tests.
- Introduced `applyDRepCert` function to streamline DRep certificate operations (register, update, retire) in `buildDRepCertTx.ts`. - Updated `RegisterDRep`, `Retire`, and `UpdateDRep` components to utilize the new `applyDRepCert` function for better code reuse and clarity. - Added Jest tests for DRep certificate functionality in `drepCert.test.ts`, covering various scenarios including registration, update, and retirement. - Created utility functions and fixtures for testing in `cborUtils.ts`, `fixtures.ts`, and `mockProvider.ts`. - Established a GitHub Actions workflow for running unit tests and uploading coverage reports. - Set coverage thresholds for critical files to ensure code quality.
…handling - Updated proxy transaction APIs to utilize `completeTxWithFreshCostModels` for transaction completion, enhancing cost model handling. - Adjusted `getTxBuilder` to accept a flag for using the CSL serializer, improving flexibility in transaction building. - Enhanced unit tests for proxy cleanup, setup, spend, vote, and DRep certificate APIs to validate the new transaction completion logic. - Added error handling for PPView hash mismatches during transaction submission, ensuring better feedback on transaction integrity issues.
- Added a new test command for TRPC in package.json to facilitate targeted testing of TRPC-related components. - Updated the unit test workflow to correct the test path pattern for transaction builder tests, ensuring accurate test execution. - Removed unused cborUtils.ts file to clean up the test directory and improve maintainability. - Simplified infrastructure tests by removing unnecessary cbor-x decoding tests.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…e tests - Refactored imports to streamline the usage of `completeTxWithFreshCostModels` across the codebase. - Updated unit tests to reflect changes in cost model handling, including support for raw arrays and ordering of indexed cost model objects. - Added new test cases to validate the rejection of improperly ordered cost model objects, ensuring robustness in transaction processing.
- Integrated functions to extract and filter blocked UTxOs from pending transactions, improving the robustness of proxy transaction processing. - Updated `MeshProxyContract` to utilize blocked UTxO references when selecting UTxOs for spending, ensuring only available UTxOs are used. - Enhanced `ProxyControl` component to manage blocked UTxOs and ensure proper handling of available UTxOs for transactions. - Refactored UTxO selection logic to improve clarity and maintainability in the proxy transaction workflow.
- Updated `proxySpend.ts` and `proxyVote.ts` to use `selectAuthTokenUtxo` for selecting the auth token UTxO, incorporating blocked UTxO references. - Introduced new utility functions in `utxoUtils.ts` for selecting UTxOs and checking asset presence. - Added comprehensive tests for UTxO selection logic in `proxy-utxo-selection.test.ts`. - Created `txBuilders.ts` to encapsulate transaction building logic for proxy actions, including setup, spending, voting, and DRep certificate management. - Implemented cross-verification tests in `proxy-cross-verify.test.ts` to ensure consistency between direct and browser-based transaction builders.
4 tasks
…or messages in DRep components
- Updated README.md to reflect new CI stages and detailed descriptions for proxy-related scripts. - Refactored proxyBot.ts to utilize new UTxO selection utilities for setup and auth token UTxOs. - Added unit tests for new UTxO selection functions: selectSetupUtxo and accumulateFundingUtxos. - Improved proxy transaction builders to accumulate funding UTxOs and ensure sufficient lovelace for operations. - Implemented cleanupProxy method in MeshProxyContract to handle proxy UTxO cleanup and burning of auth tokens. - Enhanced error handling for insufficient lovelace scenarios in proxy operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.