<fix>[host]: reduce load.parallelismDegree default from 100 to 3#4115
Open
MatheMatrix wants to merge 1 commit into
Open
<fix>[host]: reduce load.parallelismDegree default from 100 to 3#4115MatheMatrix wants to merge 1 commit into
MatheMatrix wants to merge 1 commit into
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
6f51fb1 to
7dfb223
Compare
Resolves: ZSTAC-58095 Change-Id: I5f9108e1a3f2b4c5d6e7a8b9c0d1e2f3a4b5c6d7
7dfb223 to
cbdcbcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
load.parallelismDegree=100 combined with reconnectAllOnBoot=true causes MN to fire ConnectHostMsg for all hosts simultaneously on boot. For environments with <100 hosts, this means full concurrent reconnect flood within 15ms, overwhelming the queue.
Fix
Reduce defaultValue from 100 to 3, limiting concurrent host reconnects to 3 per batch.
Resolves: ZSTAC-58095
sync from gitlab !10013