MDEV-40080: innodb_log_archive=ON corruption - #5569
Open
dr-m wants to merge 1 commit into
Open
Conversation
log_t::write_checkpoint(): Extend the the correct file. log_t::archived_mmap_switch_prepare(): Tolerate a near-concurrent buf_flush_archive_create() from the buf_flush_page_cleaner() thread.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
log_t::write_checkpoint(): Extend the the correct file.log_t::archived_mmap_switch_prepare(): Tolerate a near-concurrentbuf_flush_archive_create()from thebuf_flush_page_cleaner()thread.This fixes up #4817. I tested both changes with the test case in MDEV-40080. The first one is for the
WITH_INNODB_PMEM=OFFcode path (pwritebased log writes), and the second one is for the memory-mapped log writes.