10.11 mdev 38869#5169
Conversation
janlindstrom
force-pushed
the
10.11-MDEV-38869
branch
from
3d643c6 to
15144d1
Compare
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Galera sequence recovery tests to improve synchronization and adds a new test suite, wsrep-recover-sequences, to verify sequence recovery behavior after server crashes. The feedback suggests correcting the mysqltest syntax for an if block in wsrep-recover-sequences.test by placing the opening brace on a new line, and removing an inconsistent trailing semicolon in a wait condition query in galera_sequences_recovery.test to prevent potential parsing issues.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| if ($log_bin) { | ||
| --let $wsrep_recover_binlog_opt = --log-bin | ||
| } |
There was a problem hiding this comment.
In mysqltest syntax, the opening curly brace { for an if block must be placed on its own line. Having it on the same line as the if condition can lead to parsing errors or unexpected behavior in some environments. Additionally, indenting the block contents improves readability.
if ($log_bin)
{
--let $wsrep_recover_binlog_opt = --log-bin
}
|
|
||
| --connection node_2 | ||
| --echo # Wait for the next_not_cached_value = 11 FROM s (1) | ||
| --let $wait_condition = SELECT next_not_cached_value = 11 FROM s; |
There was a problem hiding this comment.
The trailing semicolon inside the --let $wait_condition query is inconsistent with other wait_condition definitions in this file (which do not use semicolons). Semicolons inside wait conditions can sometimes cause issues depending on how the query is evaluated or wrapped by the test framework. It is safer and more consistent to remove it.
--let $wait_condition = SELECT next_not_cached_value = 11 FROM s
- add wsrep-auto-increment-control=OFF setting to tests' configs
so that auto-increment-{increment,offset} are used instead
- fix galera_sequences_recovery test to recover crashed node's state
before joining back the cluster; this fixes the issue with wrong
NEXTVAL() produced by the restarted node
Stabilize test using wait_conditions and forcing InnoDB checkpoint before intentionally crashing the server.
janlindstrom
force-pushed
the
10.11-MDEV-38869
branch
from
15144d1 to
bfefcc1
Compare
4 participants
No description provided.