fix(pool): handle broken connection streams and allow custom server name - #62
Open
doanhidm1 wants to merge 1 commit into
Open
fix(pool): handle broken connection streams and allow custom server name#62doanhidm1 wants to merge 1 commit into
doanhidm1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
src/custom_connection.py): Checkconn._stream_brokeninstead of accessing_readerdirectly inSafePool.fill_free_pool()to avoid missing attribute errors on custom connection implementations. Safely close recycled connections withensure_closed().src/server.py): Support dynamic server naming via theMCP_SERVER_NAMEenvironment variable (default:MariaDB_Server). Updated tool docstrings.src/tests/test_query_validation.py): Added unit testTestSafePoolto verify discarding of broken connections in the free pool.