fix(#57): _get_gate_duration now uses device calibration data - #106
Merged
Conversation
_get_gate_duration returned fixed values (1 for single-qubit, 3 for two-qubit) regardless of device data, making scheduling duration estimates inaccurate for devices with heterogeneous gate times. Fix: Look up actual gate durations from cost_model.device.gate_lengths when available, converting to abstract time units relative to average single-qubit gate duration. Fall back to 1/3 model when no device data is available. Add 3 regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces fixed 1/3 gate duration model with actual device calibration lookup. When gate_lengths are available, durations are converted to abstract time units relative to average single-qubit gate time. Falls back to 1/3 when no device data. 3 regression tests. All 355 tests pass.