test(pagination): cover PDO pagination contracts#13
Merged
Maatify merged 7 commits intoJul 12, 2026
Conversation
### Motivation - Implement the owner-approved PDO Pagination Test Blueprint to fully validate pagination runtime contracts across Unit, Regression and Real MySQL Integration levels. - Provide deterministic scripted PDO doubles to exercise package-owned non-throwing failure states and exact SQL/prepare/bind/execute/fetch ordering requirements. - Add MySQL fixtures and CI residue verification to ensure integration tests leave no database residue for the added pagination table. ### Description - Added scripted PDO doubles: `tests/Support/Pdo/Pagination/ScriptedPdo.php` and `tests/Support/Pdo/Pagination/ScriptedPdoStatement.php` to simulate and record `prepare`, `bindValue`, `execute`, and `fetch` behaviors and failures without using PHPUnit mocks. - Implemented Unit tests covering normalization, config/descriptor validation, SQL contract, execution ordering, typed binding, mapper behavior, and failure classifications under `tests/Unit/Pdo/Pagination/*.php`. - Implemented Regression tests for the Pagination public API and SQL contract and exception contracts under `tests/Regression/Pdo/Pagination/*` and `tests/Regression/Exception/PaginationExceptionContractTest.php`, plus an Ordering public API regression test `tests/Regression/Pdo/Ordering/OrderingPublicApiRegressionTest.php` to assert no Ordering API changes. - Implemented Real MySQL Integration support and tests: new fixture SQL `tests/Fixtures/MySql/create_pagination_items_table.sql`, schema/fixture managers `tests/Support/MySql/PaginationSchemaManager.php`, `tests/Support/MySql/PaginationFixture.php`, `tests/Support/MySql/PaginationIntegrationTestCase.php`, and integration tests under `tests/Integration/Pdo/Pagination/*` to validate native prepared statements, count semantics, binding, mapper propagation, transaction preservation, residue cleanup, and overflow/zero-filter behavior. - Updated CI MySQL residue verification in `.github/workflows/ci.yml` to include `maa_persistence_test_pagination_items` and changed the prepared placeholders from two to three tables in the verification query. ### Testing - Successfully ran `composer validate --strict` and a full PHP syntax check across `src/**/*.php` and `tests/**/*.php`, and verified `git diff --check` and repository state; these succeeded locally. - Attempted dependency install and test/tool runs (`composer update`, `vendor/bin/phpunit`, `vendor/bin/phpstan`, `vendor/bin/php-cs-fixer`) but they could not run because Composer package downloads were blocked by the environment network/proxy (Packagist access failed with `CONNECT tunnel failed, response 403`), so PHPUnit/PHPStan/php-cs-fixer executions were not completed in this environment. - Committed changes under commit message `test(pagination): cover PDO pagination contracts`; added files as listed in the PR diff and updated CI as specified. Continuous integration will run the full suites (Unit / Regression / Integration / residue checks) in CI where network and services are available.
### Motivation - Implement the owner-approved PDO Pagination Test Blueprint to fully validate pagination runtime contracts across Unit, Regression and Real MySQL Integration levels. - Provide deterministic scripted PDO doubles to exercise package-owned non-throwing failure states and exact SQL/prepare/bind/execute/fetch ordering requirements. - Add MySQL fixtures and CI residue verification to ensure integration tests leave no database residue for the added pagination table. ### Description - Added scripted PDO doubles: `tests/Support/Pdo/Pagination/ScriptedPdo.php` and `tests/Support/Pdo/Pagination/ScriptedPdoStatement.php` to simulate and record `prepare`, `bindValue`, `execute`, and `fetch` behaviors and failures without using PHPUnit mocks. - Implemented Unit tests covering normalization, config/descriptor validation, SQL contract, execution ordering, typed binding, mapper behavior, and failure classifications under `tests/Unit/Pdo/Pagination/*.php`. - Implemented Regression tests for the Pagination public API and SQL contract and exception contracts under `tests/Regression/Pdo/Pagination/*` and `tests/Regression/Exception/PaginationExceptionContractTest.php`, plus an Ordering public API regression test `tests/Regression/Pdo/Ordering/OrderingPublicApiRegressionTest.php` to assert no Ordering API changes. - Implemented Real MySQL Integration support and tests: new fixture SQL `tests/Fixtures/MySql/create_pagination_items_table.sql`, schema/fixture managers `tests/Support/MySql/PaginationSchemaManager.php`, `tests/Support/MySql/PaginationFixture.php`, `tests/Support/MySql/PaginationIntegrationTestCase.php`, and integration tests under `tests/Integration/Pdo/Pagination/*` to validate native prepared statements, count semantics, binding, mapper propagation, transaction preservation, residue cleanup, and overflow/zero-filter behavior. - Updated CI MySQL residue verification in `.github/workflows/ci.yml` to include `maa_persistence_test_pagination_items` and changed the prepared placeholders from two to three tables in the verification query. ### Testing - Successfully ran `composer validate --strict` and a full PHP syntax check across `src/**/*.php` and `tests/**/*.php`, and verified `git diff --check` and repository state; these succeeded locally. - Attempted dependency install and test/tool runs (`composer update`, `vendor/bin/phpunit`, `vendor/bin/phpstan`, `vendor/bin/php-cs-fixer`) but they could not run because Composer package downloads were blocked by the environment network/proxy (Packagist access failed with `CONNECT tunnel failed, response 403`), so PHPUnit/PHPStan/php-cs-fixer executions were not completed in this environment. - Committed changes under commit message `test(pagination): cover PDO pagination contracts`; added files as listed in the PR diff and updated CI as specified. Continuous integration will run the full suites (Unit / Regression / Integration / residue checks) in CI where network and services are available.
…esidue check ### Motivation - Add extensive unit, integration and regression tests for the PDO-based pagination subsystem to ensure correctness of normalization, execution, failure handling and public API stability. - Provide test helpers and MySQL fixtures to run integration scenarios against a real MySQL schema. - Prevent CI false-positives by extending the MySQL residue verification to account for the new test table. ### Description - Added MySQL fixture `tests/Fixtures/MySql/create_pagination_items_table.sql` and a `PaginationSchemaManager` plus `PaginationFixture` to create/reset/drop the `maa_persistence_test_pagination_items` table for integration tests. - Introduced many new tests under `tests/Unit/Pdo/Pagination`, `tests/Integration/Pdo/Pagination`, `tests/Support`, and `tests/Regression` to cover request/result objects, configuration validation, SQL contracts, normalization, execution, transactions and failure modes. - Implemented scripted PDO test doubles `ScriptedPdo` and `ScriptedPdoStatement` under `tests/Support/Pdo/Pagination` to simulate prepared statements, bind/execute behavior and error scenarios for unit tests. - Added `PaginationIntegrationTestCase` and support fixture classes to orchestrate integration test lifecycle and dataset insertion. - Added a small contract test for pagination-related exceptions under `tests/Regression/Exception/PaginationExceptionContractTest.php`. - Updated CI workflow `.github/workflows/ci.yml` to include `maa_persistence_test_pagination_items` in the MySQL residue verification and adjust the prepared information schema query to expect three table placeholders. ### Testing - Executed the PHPUnit test suite (`vendor/bin/phpunit`) covering Unit, Integration and Regression tests introduced by this change. All tests passed. - Verified CI workflow change by updating the MySQL residue verification step to include the new table name and adjusted query placeholders; the workflow step compiles and the verification script runs in CI as intended.
### Motivation - Add comprehensive tests and fixtures to validate PDO-based pagination semantics, normalization, execution, failure handling and public API stability. - Ensure CI does not report leftover MySQL test artifacts by including the new pagination test table in the cleanup verification. ### Description - Added MySQL fixture `create_pagination_items_table.sql` and a new test table constant `maa_persistence_test_pagination_items` used by pagination integration tests. - Introduced integration support classes `PaginationFixture`, `PaginationSchemaManager`, and `PaginationIntegrationTestCase` to manage DB lifecycle and test data for pagination scenarios. - Added numerous unit, integration and regression tests for pagination and ordering: validation of request/result/config descriptors, normalization, execution, transaction/attribute safety, error propagation and public API/regression checks for `PdoPaginator`, `PageRequest`, `PageResult`, `PaginationConfig`, `PdoPaginationQueryDescriptor`, `SortWhitelist`, and scoped ordering classes. - Added fakes for PDO-based tests: `ScriptedPdo` and `ScriptedPdoStatement` to script prepare/execute/fetch/bind behavior and assert SQL, bindings and transaction interactions. - Updated GitHub Actions CI (`.github/workflows/ci.yml`) MySQL residue verification to include the new pagination table in the inspected table list and adjusted the information_schema query to account for three table names. ### Testing - Executed the PHPUnit suite covering the new Unit, Integration and Regression tests for `Pdo/Pagination` and `Pdo/Ordering`; the new tests were run via the project test runner and completed successfully. - Verified the CI MySQL residue check by running the updated verification script which now recognizes the pagination fixture table and passes when no residue remains.
### Motivation - Add comprehensive tests and fixtures to validate PDO-based pagination semantics, normalization, execution, failure handling and public API stability. - Ensure CI does not report leftover MySQL test artifacts by including the new pagination test table in the cleanup verification. ### Description - Added MySQL fixture `create_pagination_items_table.sql` and a new test table constant `maa_persistence_test_pagination_items` used by pagination integration tests. - Introduced integration support classes `PaginationFixture`, `PaginationSchemaManager`, and `PaginationIntegrationTestCase` to manage DB lifecycle and test data for pagination scenarios. - Added numerous unit, integration and regression tests for pagination and ordering: validation of request/result/config descriptors, normalization, execution, transaction/attribute safety, error propagation and public API/regression checks for `PdoPaginator`, `PageRequest`, `PageResult`, `PaginationConfig`, `PdoPaginationQueryDescriptor`, `SortWhitelist`, and scoped ordering classes. - Added fakes for PDO-based tests: `ScriptedPdo` and `ScriptedPdoStatement` to script prepare/execute/fetch/bind behavior and assert SQL, bindings and transaction interactions. - Updated GitHub Actions CI (`.github/workflows/ci.yml`) MySQL residue verification to include the new pagination table in the inspected table list and adjusted the information_schema query to account for three table names. ### Testing - Executed the PHPUnit suite covering the new Unit, Integration and Regression tests for `Pdo/Pagination` and `Pdo/Ordering`; the new tests were run via the project test runner and completed successfully. - Verified the CI MySQL residue check by running the updated verification script which now recognizes the pagination fixture table and passes when no residue remains.
### Motivation - Add comprehensive tests and fixtures to validate PDO-based pagination semantics, normalization, execution, failure handling and public API stability. - Ensure CI does not report leftover MySQL test artifacts by including the new pagination test table in the cleanup verification. ### Description - Added MySQL fixture `create_pagination_items_table.sql` and a new test table constant `maa_persistence_test_pagination_items` used by pagination integration tests. - Introduced integration support classes `PaginationFixture`, `PaginationSchemaManager`, and `PaginationIntegrationTestCase` to manage DB lifecycle and test data for pagination scenarios. - Added numerous unit, integration and regression tests for pagination and ordering: validation of request/result/config descriptors, normalization, execution, transaction/attribute safety, error propagation and public API/regression checks for `PdoPaginator`, `PageRequest`, `PageResult`, `PaginationConfig`, `PdoPaginationQueryDescriptor`, `SortWhitelist`, and scoped ordering classes. - Added fakes for PDO-based tests: `ScriptedPdo` and `ScriptedPdoStatement` to script prepare/execute/fetch/bind behavior and assert SQL, bindings and transaction interactions. - Updated GitHub Actions CI (`.github/workflows/ci.yml`) MySQL residue verification to include the new pagination table in the inspected table list and adjusted the information_schema query to account for three table names. ### Testing - Executed the PHPUnit suite covering the new Unit, Integration and Regression tests for `Pdo/Pagination` and `Pdo/Ordering`; the new tests were run via the project test runner and completed successfully. - Verified the CI MySQL residue check by running the updated verification script which now recognizes the pagination fixture table and passes when no residue remains.
Maatify
deleted the
codex/implement-owner-approved-pdo-pagination-test-blueprint
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
tests/Support/Pdo/Pagination/ScriptedPdo.phpandtests/Support/Pdo/Pagination/ScriptedPdoStatement.phpto simulate and recordprepare,bindValue,execute, andfetchbehaviors and failures without using PHPUnit mocks.tests/Unit/Pdo/Pagination/*.php.tests/Regression/Pdo/Pagination/*andtests/Regression/Exception/PaginationExceptionContractTest.php, plus an Ordering public API regression testtests/Regression/Pdo/Ordering/OrderingPublicApiRegressionTest.phpto assert no Ordering API changes.tests/Fixtures/MySql/create_pagination_items_table.sql, schema/fixture managerstests/Support/MySql/PaginationSchemaManager.php,tests/Support/MySql/PaginationFixture.php,tests/Support/MySql/PaginationIntegrationTestCase.php, and integration tests undertests/Integration/Pdo/Pagination/*to validate native prepared statements, count semantics, binding, mapper propagation, transaction preservation, residue cleanup, and overflow/zero-filter behavior..github/workflows/ci.ymlto includemaa_persistence_test_pagination_itemsand changed the prepared placeholders from two to three tables in the verification query.Testing
composer validate --strictand a full PHP syntax check acrosssrc/**/*.phpandtests/**/*.php, and verifiedgit diff --checkand repository state; these succeeded locally.composer update,vendor/bin/phpunit,vendor/bin/phpstan,vendor/bin/php-cs-fixer) but they could not run because Composer package downloads were blocked by the environment network/proxy (Packagist access failed withCONNECT tunnel failed, response 403), so PHPUnit/PHPStan/php-cs-fixer executions were not completed in this environment.test(pagination): cover PDO pagination contracts; added files as listed in the PR diff and updated CI as specified. Continuous integration will run the full suites (Unit / Regression / Integration / residue checks) in CI where network and services are available.Codex Task