feat(pagination): implement PDO offset pagination runtime#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/Pdo/Pagination:PageRequest,SortDirectionEnum,SortWhitelist,PaginationConfig,PdoPaginationQueryDescriptor,PageResult, andPdoPaginator, implementing normalization, whitelist quoting, descriptor validation, count execution, ORDER BY + tie-breaker assembly, typed binding, fetch/mapping, andPageResultinvariants.src/Exception:InvalidPaginationConfigurationException,InvalidPaginationQueryException, andPaginationExecutionException, each following the existing package exception pattern and implementingPersistenceException.bindValue()usage, zero-result and overflow behavior, and the exactpaginate()execution flow as specified by the blueprint/contract.Testing
php -lagainst the 10 added files and received "No syntax errors detected" for all files.composer analysewhich failed in this environment because thephpstanbinary is not available (phpstan: not found).composer testwhich failed in this environment because thephpunitbinary is not available (phpunit: not found).5de52190625f22e42e41d88621276c4a090de0beand the change was committed as HEAD96b10c46d57173d3b3347db5d66bdb28e1b42393.Codex Task