Fix BigQuery datetime subtraction in arterial_line_durations.sql#2007
Closed
Chessing234 wants to merge 1 commit into
Closed
Fix BigQuery datetime subtraction in arterial_line_durations.sql#2007Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes #843. Running
mimic-iii/concepts/durations/arterial_line_durations.sqlon BigQuery fails withNo matching signature for operator - for argument types: DATETIME, DATETIME.Root cause
Line 134 uses PostgreSQL interval subtraction (
charttime - charttime_lag), which BigQuery does not support for DATETIME values.Why this fix is correct
The same query already uses
DATETIME_DIFF(charttime, charttime_lag, HOUR)on line 138 for the related 16-hour threshold check. Replacing the subtraction with the same BigQuery function makes the duration column valid and consistent with the rest of the file.Made with Cursor