Skip to content

fix(mm): ship pnpm-workspace.yaml into the Docker deps stage - #61

Merged
shev-titan merged 1 commit into
devfrom
fix/mm-docker-pnpm-workspace
Aug 17, 2026
Merged

fix(mm): ship pnpm-workspace.yaml into the Docker deps stage#61
shev-titan merged 1 commit into
devfrom
fix/mm-docker-pnpm-workspace

Conversation

@lsheva

@lsheva lsheva commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Summary

The dev market-maker deploy has been failing since the pnpm 11 adoption, so the
service is still running the image built from c614362 (Aug 7). That image's
futures own-order bootstrap calls getUserOrders, which no longer exists on
HashPowerFutures, so all three futures expiries sit quarantined and 20 of the
MM's own orders are resting on-chain unmanaged. Perps is unaffected.

The build allowances were correctly moved to market-maker/pnpm-workspace.yaml
in c4c6153, but the Docker deps stage only copies package.json and
pnpm-lock.yaml. pnpm 11 turns ignored build scripts into a hard error, so the
install aborts and no image is published:

[ERR_PNPM_IGNORED_BUILDS] Ignored build scripts: @arbitrum/nitro-contracts@3.0.0, keccak@3.0.4, secp256k1@4.0.4
ERROR: failed to build: process "/bin/sh -c pnpm install --frozen-lockfile --prod" did not complete successfully: exit code: 1

Copying pnpm-workspace.yaml alongside the manifest and lockfile is enough. The
getUserOrders fix itself is already on dev (f807ff7) and needs no code change
— it just needs an image to ship in.

Test plan

  • Deploy workflow builds and pushes an image instead of failing at the deps stage
  • GET https://futuresmm.dev.hashpower.exchange/health reports the new commitHash
  • All three futures:* markets report breaker: active with consecutiveErrors: 0
  • The 20 pre-existing resting futures orders are picked up and reconciled

Verified locally that pnpm install --frozen-lockfile --prod reproduces
ERR_PNPM_IGNORED_BUILDS with only the two files present, and that all futures
view functions the MM calls (including getUserOrdersAtExpiration) resolve
against the deployed contract.

pnpm 11 stopped reading build allowances from package.json and turned ignored
build scripts into a hard install error. The allowances were moved to
market-maker/pnpm-workspace.yaml, but the deps stage only copies package.json
and pnpm-lock.yaml, so `pnpm install --frozen-lockfile --prod` still aborted
with ERR_PNPM_IGNORED_BUILDS and no image was published.

That left the dev market-maker pinned to a 10-day-old image whose futures
own-order bootstrap still calls the removed `getUserOrders`, quarantining every
futures expiry.
@shev-titan
shev-titan merged commit a6dbfe7 into dev Aug 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants