fix(mm): ship pnpm-workspace.yaml into the Docker deps stage - #61
Merged
Conversation
pnpm 11 stopped reading build allowances from package.json and turned ignored build scripts into a hard install error. The allowances were moved to market-maker/pnpm-workspace.yaml, but the deps stage only copies package.json and pnpm-lock.yaml, so `pnpm install --frozen-lockfile --prod` still aborted with ERR_PNPM_IGNORED_BUILDS and no image was published. That left the dev market-maker pinned to a 10-day-old image whose futures own-order bootstrap still calls the removed `getUserOrders`, quarantining every futures expiry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dev market-maker deploy has been failing since the pnpm 11 adoption, so the
service is still running the image built from
c614362(Aug 7). That image'sfutures own-order bootstrap calls
getUserOrders, which no longer exists onHashPowerFutures, so all three futures expiries sitquarantinedand 20 of theMM's own orders are resting on-chain unmanaged. Perps is unaffected.
The build allowances were correctly moved to
market-maker/pnpm-workspace.yamlin c4c6153, but the Docker
depsstage only copiespackage.jsonandpnpm-lock.yaml. pnpm 11 turns ignored build scripts into a hard error, so theinstall aborts and no image is published:
Copying
pnpm-workspace.yamlalongside the manifest and lockfile is enough. ThegetUserOrdersfix itself is already ondev(f807ff7) and needs no code change— it just needs an image to ship in.
Test plan
GET https://futuresmm.dev.hashpower.exchange/healthreports the newcommitHashfutures:*markets reportbreaker: activewithconsecutiveErrors: 0Verified locally that
pnpm install --frozen-lockfile --prodreproducesERR_PNPM_IGNORED_BUILDSwith only the two files present, and that all futuresview functions the MM calls (including
getUserOrdersAtExpiration) resolveagainst the deployed contract.