fix: on-repeat playlist now affected by enrich metadata setting#205
Merged
Merged
Conversation
Owner
|
Thanks for the PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed some issues with On-repeat regarding enriching metadata.
• on-repeat was silently skipping the enrich step entirely despite being toggled on in settings. Turns out it exists
QueryTracksearly throughgetTopRecordingsbefore ever actually reaching the block whereenrichTracksgets called. So ENRICH_TRACK_METADATA never actually has an effect on that playlist.• Added
recording_mbidtoTopRecordings. TopRecordings was missingrecording_mbidfrom LB, so every track had a missing MBID, setting every songsrecording_mbids=as blank and returning a 400 error, resulting in dirty rips being synced over to plex/jellyfin/navidrome.