perf(dflash): add opt-in exact prefill bands - #590
Draft
cheese-cakee wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this draft does
This is a hardware-blocked candidate for the August 10 DeepSeek V4 exact-prefill objective. It does not claim the 1.5x target.
DFLASH_DS4_EXACT_PREFILL_BANDS=1path for exact prefill widths 2 through 4.--chunk 1remains the explicit escape hatch.Why it is a draft
Neither lucebox3 nor lucebox5 was available. This branch has no HIP/gfx1151 production-model differential, no issue-#516 cached-graph burn-in, no sanitizer result, no performance profile, and no lucebox5 four-cell benchmark. It is not ready to merge or use for a performance claim.
The target benchmark contract is also incomplete. The default acceptance interpretation remains:
median heterogeneous-candidate throughput / median Strix-candidate throughput >= 1.5with matched heterogeneous baseline/candidate and Strix baseline/candidate cells.
Local evidence
Base:
4fa8937c69aa68658a14ec3cab16e1da22886dd0Head:
ed8991707d25cfde956e2d599f4570514bc0146cPassed:
deepseek4_graph.cppcompiled successfully after the graph-hook change.git diff --check, staged diff checks, andgit show --checkpass.Not passed or not run:
test_deepseek4_unittarget did not finish. Earlier attempts failed while compiling vendoredmmvq.cuwith WSL service errors; the final single-job attempt timed out after five minutes. This is compile-only evidence, not a unit-test pass.Required next validation
On lucebox3:
ggml_set_rowsfaults on HIP/ROCm after many reuses of a cached single-token graph (Strix Halo / gfx1151) #516 cached set-rows burn-in.Then run the matched four-cell acceptance on lucebox5 with identical model SHAs, inputs, settings, clocks, caches, warmups, and sample counts. Report medians, dispersion, both before/after changes, and the heterogeneous-after / Strix-after ratio.
Integration notes
This touches nearby backend/graph/docs code also changed by #548 and #554. Those changes need a semantic rebase and another review if they land first. Drafts #569/#575/#577 and lossy PFlash #589 are not acceptance evidence for this exact-prefill change.