fix: black screen when entry list is empty - #723
Open
ericreinsmidt wants to merge 1 commit into
Open
Conversation
When Tools are disabled on a fresh install with no ROMs, the main list is empty but multiple code paths access entries without bounds checks. Added total>0 guards and null-safe patterns to prevent crashes and render a usable empty state instead of a black screen. Fixes LoveRetro#712
ericreinsmidt
force-pushed
the
fix/empty-list-black-screen
branch
from
May 19, 2026 03:24
6ff4579 to
44ea223
Compare
lepht
pushed a commit
to lepht/nexterUI
that referenced
this pull request
Aug 12, 2026
Closes #6. Adopted from upstream LoveRetro#723 by Eric Reinsmidt, taken while upstream is still GPL-3.0 (see LoveRetro#765). top->entries->items[top->selected] was loaded unconditionally in both the input and the render path, so an empty directory read an uninitialised pointer out of the capacity-8 allocation Array_new() never clears. The render path then ran assert(entry) over it, which is an abort in a debug build rather than a latent read. This is the fix #6 asked for: hoist the count check above the load in both paths instead of relying on the downstream total>0 guards. The L1/R1 alpha jump handlers get the same treatment, and the assert goes away. Every remaining read of entries->items[top->selected] in this file is now behind a count or total>0 check. Array_new() still leaves its capacity uninitialised - that is unchanged and now unreachable, not fixed. Upstream wrote this for the empty-root case (no roms, Tools hidden); it covers the ordinary empty Roms/ folder #6 describes by the same route. Co-Authored-By: Eric Reinsmidt <eric@reinsmidt.com>
lepht
pushed a commit
to lepht/nexterUI
that referenced
this pull request
Aug 12, 2026
Closes #6. Adopted from upstream LoveRetro#723 by Eric Reinsmidt, taken while upstream is still GPL-3.0 (see LoveRetro#765). top->entries->items[top->selected] was loaded unconditionally in both the input and the render path, so an empty directory read an uninitialised pointer out of the capacity-8 allocation Array_new() never clears. The render path then ran assert(entry) over it, which is an abort in a debug build rather than a latent read. This is the fix #6 asked for: hoist the count check above the load in both paths instead of relying on the downstream total>0 guards. The L1/R1 alpha jump handlers get the same treatment, and the assert goes away. Every remaining read of entries->items[top->selected] in this file is now behind a count or total>0 check. Array_new() still leaves its capacity uninitialised - that is unchanged and now unreachable, not fixed. Upstream wrote this for the empty-root case (no roms, Tools hidden); it covers the ordinary empty Roms/ folder #6 describes by the same route. Co-Authored-By: Eric Reinsmidt <eric@reinsmidt.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
total>0guards and null-safe patterns to prevent crashes and render a usable empty stateFixes #712
Test plan