Skip to content

fix(Linux): route Xbox pads through UHID - #115

Draft
ReenigneArcher wants to merge 1 commit into
masterfrom
fix/linux/xbox-uhid
Draft

fix(Linux): route Xbox pads through UHID#115
ReenigneArcher wants to merge 1 commit into
masterfrom
fix/linux/xbox-uhid

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Aug 28, 2026

Copy link
Copy Markdown
Member

Description

Linux now prefers UHID for Xbox One and Xbox Series gamepads so their native descriptors and SDL USB GIP four-motor output can be handled correctly. The profiles and adapter support now expose trigger rumble, the report parser decodes SDL's wrapped rumble command into ordinary and trigger-rumble callbacks, and the uinput fallback explicitly drops trigger-rumble capability while keeping standard rumble. Documentation and tests were updated to reflect the new backend behavior and compatibility expectations.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher
ReenigneArcher force-pushed the fix/linux/xbox-uhid branch 2 times, most recently from becd909 to 73f0e1a Compare August 28, 2026 19:28
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
220 2 218 2
View the top 2 failed test(s) by shortest run time
LinuxConsumerTest::SdlSeesXboxSeriesCanonicalButtons
Stack Traces | 0.132s run time
.../tests/unit/test_linux_consumers.cpp:568
Expected equality of these values:
  SDL_GameControllerRumble(controller, 0x5678, 0x1234, 1000)
    Which is: -1
  0
That operation is not supported
LinuxConsumerTest::SdlSeesXboxOneCanonicalButtons
Stack Traces | 0.139s run time
.../tests/unit/test_linux_consumers.cpp:568
Expected equality of these values:
  SDL_GameControllerRumble(controller, 0x5678, 0x1234, 1000)
    Which is: -1
  0
That operation is not supported

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Linux now prefers UHID for Xbox One and Xbox Series gamepads so their native descriptors and SDL USB GIP four-motor output can be handled correctly. The profiles and adapter support now expose trigger rumble, the report parser decodes SDL's wrapped rumble command into ordinary and trigger-rumble callbacks, and the uinput fallback explicitly drops trigger-rumble capability while keeping standard rumble. Documentation and tests were updated to reflect the new backend behavior and compatibility expectations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux: support Xbox Impulse Triggers

1 participant