Skip to content

build: retire the empty Submakefiles left behind by 82f05bccb3 - #4456

Merged
BsAtHome merged 1 commit into
LinuxCNC:masterfrom
grandixximo:retire-empty-submakefiles
Aug 23, 2026
Merged

build: retire the empty Submakefiles left behind by 82f05bccb3#4456
BsAtHome merged 1 commit into
LinuxCNC:masterfrom
grandixximo:retire-empty-submakefiles

Conversation

@grandixximo

Copy link
Copy Markdown
Contributor

They contribute nothing, and -include $(wildcard $(SUBMAKEFILES)) does not need the file to exist. Clean build with --enable-werror.

@BsAtHome

Copy link
Copy Markdown
Contributor

The Makefile expands this from SUBDIRS (apparently sole reason for it to be there). You removed the empty Submakefile, but the directories are still mentioned. Intentional?

Their SUBDIRS entries go with them, since SUBDIRS exists only to name
the Submakefiles.
@grandixximo
grandixximo force-pushed the retire-empty-submakefiles branch from 27f009a to cfdd5ab Compare August 23, 2026 12:56
@grandixximo

Copy link
Copy Markdown
Contributor Author

Not intentional, just missed. Removed now, the seven entries go with the files.

Same on #4452, where deleting hal/drivers/mesa-hostmot2/Submakefile left its entry behind too. That one belongs there rather than here, since removing the entry while the file still exists would drop the hostmot2-serial.h copy rule if this merged first.

@BsAtHome
BsAtHome merged commit 2e62cd9 into LinuxCNC:master Aug 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants