hal: Remove pyhal module that is incompatible with getter/setter - #4450
Open
BsAtHome wants to merge 1 commit into
Open
hal: Remove pyhal module that is incompatible with getter/setter#4450BsAtHome wants to merge 1 commit into
BsAtHome wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pyhal module loads hal_lib using the Python CDLL interface and is incompatible with getter/setter because uses direct HAL memory access. All previous usage patterns have already been moved into halmodule (the HAL_PORT stuff) and all dependent raster code was ported some time ago. The pyhal module also carried a deprecated message.
The only place pyhal.py was still in use was in
tests/pyhal. The other instance, a remap in a sim config, was actually not using the module at all.