src: include exported headers with angle brackets where they are used - #4448
Merged
Conversation
BsAtHome
reviewed
Aug 22, 2026
Contributor
|
The inifile.hh fixes reminds me of the fact that liblinuxcncini.so should also be moved outside the emc tree. It is a separate library stuff links against. Yet another cleanup ;-) |
The build copies every SRCHEADERS entry into include/, so an exported header exists twice: the source under src/ and the copy modules compile against. A quoted include searches the includer's own directory before the -I path, an angled include does not, so the two forms can reach different copies of the same header and both compile. An exported header travels to include/ and takes its siblings with it, so it keeps the quoted form and finds them wherever it lands, and so does its implementation, wanting the source rather than a stale export. The files changed here are users, and build out of tree where only the exported copies exist.
grandixximo
force-pushed
the
include-brackets
branch
from
August 22, 2026 10:33
8685933 to
2751ae8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@BsAtHome The include-type half of #4375, split out as you asked. The check stays there.
The build copies every
SRCHEADERSentry intoinclude/, so an exported header exists twice, the source undersrc/and the copy modules compile against. A quoted include searches the includer's own directory before the-Ipath and an angled include does not, so the two forms can reach different copies of the same header and both compile.An exported header keeps the quoted form so it still finds its siblings once it lands in
include/, and so does its implementation, which wants the source rather than a stale export. The seven files here are users, and build out of tree where only the exported copies exist.