include-dep-report: bucket by what the build links, not by directory depth - #4446
Merged
Conversation
…depth The six libnml subdirectories are in SUBDIRS and each has an empty Submakefile, present only to satisfy SUBMAKEFILES. Every source is listed in libnml/Submakefile and links into one libnml.so, so the five-way cycle the report showed between them was a directory layout, not a dependency. Fold a subdirectory into its parent when the parent's Submakefile lists its sources. emc/tp keeps its own bucket, the top-level Makefile builds it into tpmod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUBDIRSnames the six libnml subdirectories and each has an emptySubmakefile, present only becauseSUBMAKEFILESderives one path per entry. Every source is listed inlibnml/Submakefileand links into onelibnml.so, so the five-way cycle the report showed between them was a directory layout, not a dependency.A subdirectory is folded into its parent when the parent's
Submakefilenames its sources. An emptySubmakefileon its own is not the test:emc/tphas one too, and folding that intoemcwould have hidden the motion/tp cycle. The top-levelMakefilebuilds it into tpmod, so it keeps its own bucket.On master:
The docstring and the report header both said bucketing followed
SUBDIRSgranularity, whichmodule_ofnever did. They now describe the rule the code applies.Part of the dependency work behind #4375.