emc: cut the nml_intf dependency on tooldata - #4445
Merged
Merged
Conversation
EMC_TOOL_STAT::operator= has no caller; deleting it builds the tree in both the default and --enable-toolnml configurations, and its stated reason, array members, never applied since implicit copy assignment copies those anyway. The default state of an entry moves next to the type as CANON_TOOL_TABLE_INIT, so the constructor no longer borrows tooldata_entry_init(). Default member initializers would read better but make the struct non-POD, which clang rejects for tooldata_entry_init(), declared extern "C" and returning it by value.
grandixximo
force-pushed
the
nml-tooldata-cut
branch
from
August 22, 2026 02:31
36768bb to
2508c98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emc/nml_intfandemc/tooldatainclude each other. The reverse edge is one line,emcops.cc:21, held by two calls inEMC_TOOL_STAT.operator=has no caller: marking it= deletebuilds the tree in both the default and--enable-toolnmlconfigurations. Its comment claims array members need it, but implicit copy assignment copies those, and the default build has no array member. The copy constructor is already deleted.The constructor call is a plain initializer for nml_intf's own
CANON_TOOL_TABLE, so the default state moves next to the type asCANON_TOOL_TABLE_INIT. Default member initializers would read better, but they make the struct non-POD and clang then rejectstooldata_entry_init(), which is declaredextern "C"and returns it by value. The struct itself is untouched, which matters because it lands in the mmapped tool store.scripts/include-dep-report.pygoes from three cycles over nine directories to two over seven.Part of the dependency work behind #4375.