gladevcp: fix velocity DRO row position on non-lathes - #4444
Open
grandixximo wants to merge 1 commit into
Open
Conversation
The lathe test guarding the insertion index in hal_gremlin's dro_format referenced the bound method instead of calling it, so it was always truthy and every machine got the lathe offset. On a mill the Vel row was inserted one slot too low, below the blank separator that precedes the G5x offset block, instead of directly under the axis rows. Lathe output is unchanged, since there the extra offset is what the inserted Rad/Dia row calls for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hal_gremlin'sdro_formatcomputes where to insert theVelrow in the DRO offsets column, and the lathe test guarding that index referenced the bound method rather than calling it:A bound method is always truthy, so every machine got the lathe offset. On a mill the
Velrow was inserted one slot too low, below the blank separator that precedes the G5x offset block, instead of directly under the axis rows.XYZ mill, before:
after:
Lathe output is unchanged. There the blanked X slot plus the inserted Rad/Dia row is exactly what the extra
+1accounts for, so the index lands in the same place before and after.I checked the rest of the tree for the same pattern; this was the only paren-less
self.is_lathereference.