Gmoccapy: Fixes in calculator and tooledit_widget

[Sigma1912]

• Calculator no longer hands back float strings when asking for integers
• Tooledit_widget now truncates float input values to positive integer values for the tool- and pocket number

Fixes #4435

[hansu]

That was quick, thanks.

I haven't dug deep into this but I wonder if we should fix it better in tooledit (or additionally).
It fails in line int(new_text) with new text = "5.000" for example.

linuxcnc/lib/python/gladevcp/tooledit_widget.py

Lines 513 to 523 in bae5676

	if col in(1,2):
	try:
	self.model[path][col] = int(new_text)
	except:
	pass
	# validate input for float columns
	elif col in range(3,15):
	try:
	self.model[path][col] = f"{float(new_text.replace(',', '.')):10.4f}"
	except:
	pass

This would also fix it in this case. But it might be bad if this function gets accidentally a float value which is cut then.

    if col in(1,2):
        try:
            import re
            self.model[path][col] = int(re.split(r'[.,]', new_text)[0])

[Sigma1912]

I noticed that the pocket number column currently allows negative integer values, which I don't think is correct?
So Tool and Pocket number columns will now truncate any float to the absolute integer value. I'm not sure we still need the dot,comma replacement but kept it just in case.

[hansu]

I noticed that the pocket number column currently allows negative integer values, which I don't think is correct?

I don't know. Maybe one want to disable a tool by setting pocket to -1?
I think the bigger problem is that duplicated tool numbers and pocket numbers are allowed.

[grandixximo]

I use duplicate pocket numbers, stacked tools

[Sigma1912]

Just checked in Axis gui (if that is anything to go by):

• allows duplicate pocket numbers
• errors out on negative pocket numbers

And yes, there is definitely a use for duplicate pocket number.