fix: correct iOS Safari viewport height on sign request - #7964
Merged
Conversation
Signed-off-by: Bastian de Byl <bastian@debyl.io>
bdebyl
force-pushed
the
fix_safari_ios_viewheight
branch
from
August 2, 2026 15:01
d006af6 to
e1b466f
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 173 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
|
/backport to stable34 |
Member
|
/backport to stable33 |
Member
|
/backport to stable32 |
Member
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes the external signing page being cut off at the bottom on iOS Safari.
ExternalApp.vuesizeshtml body #content— and, undermax-width: 512px,#app-sidebar— toheight: 100vhwithposition: fixed. iOS Safari resolves100vhagainst the large viewport i.e. as though the browser chrome were hidden. The element therefore extends behind the bottom toolbar, and its lower edge cannot be scrolled into view / is inaccessible.On the signing page that lower edge is the action bar, so a signer on an iPhone sees it clipped and cannot reliably tap it. Signing is effectively blocked on mobile Safari.
This pairs each
100vhwith a following100dvh. The dynamic viewport unit tracks the browser chrome as it shows and hides, which is the intended behaviour here.Why it is paired with
100vhThe
100vhdeclaration is kept first, so a browser withoutdvhsupport simply drops the second declaration and behaves exactly as it does today. From my understanding, no@supportsguard is needed and there is no regression risk for older clients.Note: I did test on other browsers, but the before/after is the same for desktop.
🧪 How to test
<aside>allowing signature defining is no longer obscured by UI elements🎨 UI / Front‑end changes
✅ Checklist