upgrade to c++23 and windows macro fixes#14
Merged
Conversation
Pistonight
force-pushed
the
update_version
branch
from
af93ba2 to
548aa05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to use c++20 features but I didn't feel like compiling my mod with 2 different standards..
The only thing that really needed fixing was cannot assign string literal to
char*c++20 to c++23 had no additional issues.
Another issue was the windows macro issue (min/max defined to something else) which i am not entirely sure if it's due to upgrading to c++20 or the formatting earlier. But it seems like the culprit is bass.h and curl.h will include windows stuff. The workaround is include our header with the undef before including bass/curl, so bass/curl will not include windows again