Improve ublox_gps Windows portability#283
Open
Tobias-Fischer wants to merge 1 commit into
Open
Conversation
This upstreams the non-duplicated Windows portability pieces from RoboStack patch patch/ros-rolling-ublox-gps.patch. The Asio io_service to io_context migration is already covered by an open upstream PR, so this commit only adds the MSVC math define, skips POSIX termios raw-mode calls on Windows, preserves and undefines the Windows ERROR macro while parsing ROS constants named ERROR, and uses auto for the MonVER extension iterator. Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
Author
|
FYI @wep21 @traversaro, this was opened from the RoboStack upstreaming tracker: RoboStack/robostack.github.io#16 Source patch: https://github.com/RoboStack/ros-rolling/blob/main/patch/ros-rolling-ublox-gps.patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of an effort to contribute RoboStack downstream patches back upstream.
Origin: RoboStack patch/ros-rolling-ublox-gps.patch, authored by Daisuke Nishimatsu.
This carries the non-duplicated Windows portability pieces from the RoboStack patch: define _USE_MATH_DEFINES for MSVC, skip POSIX termios raw-mode calls on Windows, preserve and undefine the Windows ERROR macro while parsing ROS constants named ERROR, and use auto for the MonVER extension iterator.
I intentionally did not include the Asio io_service to io_context migration here because it is already covered by upstream PR #273.