Fix ublox_msgs Windows portability#282
Open
Tobias-Fischer wants to merge 1 commit into
Open
Conversation
This upstreams the Windows-focused part of the RoboStack ublox_msgs build fix. On Windows, the system ERROR macro can collide with the ublox_msgs::Message::INF::ERROR constant. Guarding the macro locally lets the public header keep its existing API. Enabling CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS exports the ublox_msgs support library symbols for downstream consumers. Origin: patch/ros-rolling-ublox-msgs.win.patch, authored by Daisuke Nishimatsu. Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
Author
|
FYI @wep21 and @traversaro: I opened this while upstreaming RoboStack patches tracked in RoboStack/robostack.github.io#16. This one comes from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of an effort to contribute RoboStack downstream patches back upstream.
Origin:
patch/ros-rolling-ublox-msgs.win.patch, authored by Daisuke Nishimatsu.This keeps the ROS 2
ublox_msgsheaders and support library friendlier to Windows builds. The Windows SDK can defineERRORas a macro, which collides with the existingublox_msgs::Message::INF::ERRORconstant in the public header. The guard keeps the existing API while avoiding that macro collision.The support library is also built with
CMAKE_WINDOWS_EXPORT_ALL_SYMBOLSon Windows so downstream consumers can link the generated DLL without hand-maintained export annotations.