Export Message keys storage on Windows#281
Open
Tobias-Fischer wants to merge 1 commit into
Open
Conversation
This upstreams RoboStack build fix patch/ros-rolling-ublox-serialization.win.patch. Best guess rationale: the static Message::keys_ storage is part of the ublox_serialization library ABI. Marking it with UBLOX_SERIALIZATION_EXPORT makes the symbol visible when building or consuming the library as a Windows DLL. Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
Author
|
FYI @wep21 and @traversaro: this upstreams a RoboStack downstream patch tracked in RoboStack/robostack.github.io#16. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of an effort to contribute RoboStack downstream patches back upstream.
Origin: patch/ros-rolling-ublox-serialization.win.patch, authored by Daisuke Nishimatsu.
Best-guess rationale: the static Message::keys_ storage is part of the ublox_serialization library ABI. Marking it with UBLOX_SERIALIZATION_EXPORT makes the symbol visible when building or consuming the library as a Windows DLL.