check by app#1036
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns “write mode” checks with the active application’s configured write settings, and fixes write::GetWriteMode to read from the write configuration dict.
Changes:
- Update
write::GetWriteModeto useGetConfigurationAttribute write_mdpa_mode(instead of a non-existent::write::GetAttribute). - Update
spdAux::ProcShowInWriteModeto querywrite_mdpa_modefrom the application (apps::ExecuteOnApp ... GetWriteProperty) rather than from the global write namespace.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
kratos.gid/scripts/Writing/Writing.tcl |
Fixes write::GetWriteMode to read the configured write_mdpa_mode from current_configuration. |
kratos.gid/scripts/Controllers/CommonProcs.tcl |
Makes ShowInWriteMode evaluate the write mode using the owning app’s write property (write_mdpa_mode). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.