Fluid writes merged geometries by element type#1032
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GiD MDPA geometry writing flow for the Fluid application so that, when writing in geometries mode, geometry connectivities are merged by element type (e.g., all tetrahedra together, all triangles together) to avoid repeated geometry entities.
Changes:
- Added an optional
merge_by_etypeparameter towrite::writeGeometryConnectivitiesto support merging geometry output by element type. - Enabled merged-by-element-type geometry writing in the Fluid app by calling
writeGeometryConnectivitieswith the merge flag set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| kratos.gid/scripts/Writing/WriteGeometries.tcl | Adds merge-by-element-type mode and creates temporary merged groups to write consolidated Begin/End Geometries blocks. |
| kratos.gid/apps/Fluid/write/write.tcl | Enables merge-by-element-type geometry writing when write_mdpa_mode is geometries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, fluid application and all the derived apps will write the geometry section merging by element type
All tetrahedra together, all triangles together... avoiding repeated entities. See KratosMultiphysics/Kratos#12564
@RiccardoRossi