Set install directories depending on target type#374
Conversation
|
seems that this fails several CI configs |
|
Yep, I'm on it. I opened the PR to run the CI (should have done a draft). |
This reverts commit 4e452ba.
…nstead of /etc/bashrc
…aced with python3.10, instead of installing the dev package for the system's default python3. wow. I'm never going to touch this piece of shit image again. If Altair updates their docker image, it's their job to fix this crap.
|
Ok I'm done, here's a digest.
|
I am sorry that it happened. I didn't know it was used here. We shoud use the hash instead of the latest image by default to avoid these issues in the future. Feel free to notice if Rocky is broken. BTW, @ddiezrod does not work with us anymore |
CentOS 7 used to be in the CI, and I replaced it with Rocky 8 the last time I did maintenance on CoSimIO. |
|
Thanks a lot @matekelemen ! I removed the required checks, I dont think they are useful nowadays. Can you pleas push a commit to trigger the CI? |
KratosMultiphysics/Kratos#13374 attempts to merge changes from #373, but it looks like I made a mistake at the install stage.
This PR sets the install directory depending on the target type, which is different on Linux and Windows.
Works with Kratos on my (Linux) system but the real question is Windows.