Club/new site by myr124 · Pull Request #450 · KnightHacks/forge

myr124 · 2026-05-14T15:42:23Z

Why

To clean up club site files so that we can start implementing Figma from design team.

What

Closes: #ISSUE_NUMBER

Doesn't close any issues but helps devs start work on their respective pages.

Implemented navbar and gradient backgrounds with dot pattern from figma
Made routes for all pages
Modified globals.css to include these gradients, typography, colors and more so we can finetune.

Notes:

I would recommend to utilize global CSS variables to avoid duplicated code and fragmented CSS.
The gradients I have currently implemented don't match 1:1, if you guys know how to get that data from Figma accurately to convert to CSS that would be amazing (Dylan mentioned stacked gradients)

Test Plan

Current Home Page:

Other page with sample text placeholder (we should remove this comp once we put actual content):

Mobile Nav

Hamburger Menu (we can add css animations imo)

Checklist

[X ] Database: No schema changes, OR I ran pnpm db:generate and committed the generated files in packages/db/drizzle/
[X ] Environment Variables: No environment variables changed, OR I have contacted the Development Lead to modify them on Coolify BEFORE merging.

…nd text changes)

…classes to switch between the different types of buttons)

…styles easier

coderabbitai · 2026-05-14T15:42:31Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 4d4004f8-b4b3-4d8f-9d25-5f7cf8394f7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch club/new-site

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

farisAwheel · 2026-05-17T00:49:04Z

i do think the navbar should not contain the sign up buttons if it goes into hamburger mode

farisAwheel

LGTM except the navbar behaves weirdly on mid-sized screens, see prev comment

Co-authored-by: º • 🌱 kai 🌱 • º <kaisprunger@gmail.com> Co-authored-by: Carlos <carlos@catala.dev>

I take full responsibility as president for merging alone

checked by daniel made by adrian kai and bowen all good on my side

…-site

alexanderpaolini · 2026-06-13T04:26:56Z

+const fieldTriggerClassName =
+  "h-12 overflow-hidden rounded-none border-x-0 border-b-2 border-t-0 border-white/75 bg-transparent px-0 text-left text-lg font-medium text-white shadow-none transition-colors hover:border-white hover:bg-transparent hover:text-white focus:ring-0 focus-visible:ring-0 focus-visible:ring-offset-0 data-[placeholder]:text-white/35 [&>span]:block [&>span]:max-w-[calc(100%-2rem)] [&>span]:truncate [&>svg]:text-white/55 sm:h-14 sm:text-xl md:text-2xl";
+const fieldLabelClassName =
+  "text-base font-semibold leading-none text-white/85 md:text-lg";
+const optionalTextClassName =
+  "ml-2 text-sm font-medium italic text-white/45 md:text-base";
+const requiredMarkClassName =
+  "text-xl font-black text-[#ff4fd8] drop-shadow-[0_0_10px_rgba(255,79,216,0.85)] md:text-2xl";
+const checkboxClassName =
+  "mt-0.5 flex h-5 w-5 items-center justify-center border-white/45 bg-white/5 text-white shadow-none data-[state=checked]:border-white data-[state=checked]:bg-white data-[state=checked]:text-[#21103d] focus-visible:ring-white/40 [&>span>svg]:h-5 [&>span>svg]:w-5";


Why are you using class names like this rather than components?

im confused on this too but honestly its ok probably just codex shenanigans lol

alexanderpaolini · 2026-06-13T04:36:59Z

+}: {
+  profile?: { firstName?: string | null; lastName?: string | null } | null;
+  profileKind?: PassProfileKind;
+}) {


Is there a better way to represent this?

alexanderpaolini

I only looked over @forge/blade and @forge/api for the most part. Most of everything I'm asking is just curiosity

alexanderpaolini · 2026-06-13T04:44:26Z

+    if (profile && (!profile.firstName || !profile.lastName)) {
+      toast.error("Missing profile information");


I'm a bit confused why this is even possible. Since this component passes through profile, can we not just require that profile is defined? Might be something to look into.

alexanderpaolini · 2026-06-13T04:50:26Z

                >
                  {selectedJudge
-                    ? `${selectedJudge.name} — ${selectedJudge.challengeTitle}${
+                    ? `${selectedJudge.name}, ${selectedJudge.challengeTitle}${


A side effect of the control-f on m-dashes? I think this was unintentional

alexanderpaolini · 2026-06-13T04:51:28Z

                      </a>
                    ) : (
-                      "—"
+                      "Not rated"


Haven't seen what this look like, but surely the m-dash is better than Not rated. Low importance.

…ite finished

DanielJEfres · 2026-06-16T06:06:58Z

general tidbit: please mark any coomments as resolved when addressed in the changes. im unsure as to whether or not alex's comments have been addressed atm

DanielJEfres

pls read over my comments and resolve them when fixed / answer if im wrong about something. once all are resolved it's basically approved from me !

apart from what i pointed out everything looked amazing, this is a great job well done i just wanted to make sure it was as perfect as we could get it. mostly looked for accessibility or performance issues, but found some other stuff worth pointing out on the way aswell

great job chat

DanielJEfres · 2026-06-16T07:08:06Z

@@ -4,13 +4,32 @@ const config = {
  reactStrictMode: true,
  images: {
    unoptimized: true,


critical: why are images unoptimized? we should just remove this line and rely on the remote patterns and cdn r2

codex say bad. jason not know enough to no agree

myr124 added 9 commits May 13, 2026 12:45

club purge

10d745c

cleared home page and implemented new navbar (need to make coloring a…

5dddfe0

…nd text changes)

changes to navbar, radial dot pattern in globals

16d3dd3

changed regular divs to shadcn buttons with styling (we could do css …

38e7eb6

…classes to switch between the different types of buttons)

took button styles from tailwind and css classes so we can reuse the …

78b3928

…styles easier

added routes for pages

7d4f821

fine tuning gradients (they still suck)

0df617e

removed accidentally staged claude.md

83fcbf5

moved navbar and bg to layout

5813b7e

made coderabbit changes, mobile nav, breakpoint fixes for buttons

8e93cd0

farisAwheel requested changes May 21, 2026

View reviewed changes

Adr1an04 and others added 10 commits May 31, 2026 09:41

Bloomknights (#456)

f970aa1

Co-authored-by: º • 🌱 kai 🌱 • º <kaisprunger@gmail.com> Co-authored-by: Carlos <carlos@catala.dev>

Hacker application experience and background system (#458)

7d43dbf

Hacker dashboard (#461)

74399cd

I take full responsibility as president for merging alone

BloomKnights and KHix site fixes (#463)

30c7a62

checked by daniel made by adrian kai and bowen all good on my side

css changes and hacker application speed up (#465)

a8665ab

iphone cut off fix bk application

a91649b

background overlay bug fix

7408cab

shadow gradient lower

75877fb

hacker form overflow issue potential fix

26f62e3

Merge remote-tracking branch 'origin/main' into club/new-site

9160adf

Adr1an04 requested a review from a team as a code owner June 11, 2026 00:16

Adr1an04 added 2 commits June 10, 2026 18:23

Merge remote-tracking branch 'origin/club-site-staging' into club/new…

a56e72a

…-site

club site merger and pages complete

ed4fa7c

alexanderpaolini reviewed Jun 13, 2026

View reviewed changes

Comment thread apps/blade/src/app/_components/dashboard/member-dashboard/member-dashboard.tsx

alexanderpaolini reviewed Jun 13, 2026

View reviewed changes

Comment thread apps/blade/src/app/_components/dashboard/member-dashboard/download-qr-pass.tsx Outdated

alexanderpaolini reviewed Jun 13, 2026

View reviewed changes

Adr1an04 and others added 8 commits June 14, 2026 16:47

pfps, sponsors, all images in r2

57ed006

got rid of bios, added linkedin

6001b3e

animations & slight edit of sponsors

c04f3aa

update or smth

bee01c0

fixed bug and added some more companies + embedded links

d3673ce

dependency stuff or something

5cbe2dc

anims fixing, finishing blade connection, alex feedback fixes, club s…

4c000f7

…ite finished

fix format issues

a0432b3

DanielJEfres self-requested a review June 16, 2026 07:15

DanielJEfres requested changes Jun 16, 2026

View reviewed changes

coderabbitai Bot approved these changes Jun 16, 2026

View reviewed changes

kwaiidev added 2 commits June 16, 2026 04:13

there is so much poopy in my diapy (daniel fixes)

8a123df

small fix for checks

2988145

		if (profile && (!profile.firstName \|\| !profile.lastName)) {
		toast.error("Missing profile information");

Conversation

myr124 commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

What

Test Plan

Checklist

Uh oh!

coderabbitai Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

farisAwheel commented May 17, 2026

Uh oh!

farisAwheel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexanderpaolini left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DanielJEfres commented Jun 16, 2026

Uh oh!

DanielJEfres left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

myr124 commented May 14, 2026 •

edited

Loading

coderabbitai Bot commented May 14, 2026 •

edited

Loading