Skip to content

Adjust for data api client v2.2.1 GA#5

Merged
aar0np merged 1 commit into
KillrVideo:mainfrom
sl-at-ibm:SL-client-2.2.1
Jun 18, 2026
Merged

Adjust for data api client v2.2.1 GA#5
aar0np merged 1 commit into
KillrVideo:mainfrom
sl-at-ibm:SL-client-2.2.1

Conversation

@sl-at-ibm

@sl-at-ibm sl-at-ibm commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Updates to the code to adjust to the GA client (v2.2.1).

  • Naming aligment: DataApiClient => DataAPIClient
  • .Update and .Filter aliased as .TableUpdate and .TableFilter (some features are/will be specializations; naming uniformity)
  • removed PrimaryKeyFilter and CompositeKey from table filter builders (did not add anything other than cognitive load). Replaced with regular filtering syntax as required by latest client.
  • README: removed 2 mentions of the package being beta
  • likewise, bump dep version in kv-be-csharp-dataapi-table.csproj
  • stronger nullchecks in a few controller logic (etc.) to avoid null deref build warnings.

Now it builds and runs, and...

$> curl -X GET "https://localhost:7264/api/v1/health" --header "Content-Type: application/json" --http1.0
curl: (56) OpenSSL SSL_read: OpenSSL/3.5.4: error:0A000126:SSL routines::unexpected eof while reading, errno 0
"Service is up and running!"
$>

(not sure about the SSL error, probably not a big deal/a me-problem, and surely unrelated to this PR)

Note I'd like to address the ~14 remaining build warnings (mostly related to null dereference risk and a few nullable things), but this can go in a separate PR.

@aar0np aar0np left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aar0np aar0np merged commit 0d84d5c into KillrVideo:main Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants