Conversation
check for duplicate PEMs
change default start sync date for first incremental sync
removing caching of product type list
change default incremental sync range
shorten incremental sync if it is too long
add duplicate support
* add duplicate support * Update generated docs --------- Co-authored-by: Keyfactor <keyfactor@keyfactor.github.io>
treat needs_approval the same as pending on enrollments and don't ret…
There was a problem hiding this comment.
Pull request overview
Automated merge of dev-2.3 into main, primarily adding a new template parameter to request the KDC/SmartCardLogon EKU for SSL enrollments and updating related documentation/metadata.
Changes:
- Add
IncludeKDCSmartCardLogonEKUtemplate parameter and map it to DigiCert profile optionkdc_smart_card, with mutual-exclusion enforcement vsIncludeClientAuthEKU. - Update planned deprecation date messaging for
IncludeClientAuthEKU(May 2026 → March 2027). - Document the new option in README, integration manifest, and changelog.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents new IncludeKDCSmartCardLogonEKU parameter and updates EKU deprecation date text. |
| integration-manifest.json | Exposes new enrollment config field and updates EKU deprecation date text. |
| digicert-certcentral-caplugin/Constants.cs | Adds constant key for IncludeKDCSmartCardLogonEKU. |
| digicert-certcentral-caplugin/CertCentralCAPlugin.cs | Implements EKU profile option selection, validation updates, and adds parameter annotations. |
| CHANGELOG.md | Adds 2.3.0 entry describing the new EKU flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+304
to
+309
| bool clientAuth = Convert.ToBoolean(productInfo.ProductParameters[CertCentralConstants.Config.INCLUDE_CLIENT_AUTH]); | ||
| bool kdc = Convert.ToBoolean(productInfo.ProductParameters[CertCentralConstants.Config.INCLUDE_KDC]); | ||
| if (clientAuth && kdc) | ||
| { | ||
| throw new Exception($"Cannot enroll for cert with both Client Auth and KDC/SmartCardLogon EKU set to 'true'"); | ||
| } |
Comment on lines
1090
to
1094
| detailsRequest.ContainerId = null; | ||
| if (connectionInfo.ContainsKey(CertCentralConstants.Config.DIVISION_ID)) | ||
| if (productInfo.ProductParameters.ContainsKey(CertCentralConstants.Config.ENROLL_DIVISION_ID)) | ||
| { | ||
| string div = connectionInfo[CertCentralConstants.Config.DIVISION_ID].ToString(); | ||
| string div = productInfo.ProductParameters[CertCentralConstants.Config.ENROLL_DIVISION_ID].ToString(); | ||
| if (!string.IsNullOrWhiteSpace(div)) |
Comment on lines
+1125
to
+1133
| bool clientAuth = false, kdc = false; | ||
| if (productInfo.ProductParameters.ContainsKey(CertCentralConstants.Config.INCLUDE_CLIENT_AUTH)) | ||
| { | ||
| clientAuth = Convert.ToBoolean(productInfo.ProductParameters[CertCentralConstants.Config.INCLUDE_CLIENT_AUTH]); | ||
| } | ||
| if (productInfo.ProductParameters.ContainsKey(CertCentralConstants.Config.INCLUDE_KDC)) | ||
| { | ||
| kdc = Convert.ToBoolean(productInfo.ProductParameters[CertCentralConstants.Config.INCLUDE_KDC]); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge dev-2.3 to main - Automated PR