Skip to content

formatted keeper sdk package using prettier#211

Merged
sgaddala-ks merged 4 commits into
mainfrom
keepersdk-format
Jul 17, 2026
Merged

formatted keeper sdk package using prettier#211
sgaddala-ks merged 4 commits into
mainfrom
keepersdk-format

Conversation

@sgaddala-ks

Copy link
Copy Markdown
Contributor

No description provided.

@tylerccarson tylerccarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth adding a step to the main.yml workflow to ensure code formatting compliance during PR's.

Also, in a follow-up PR, make sure to add the landing commit hash to https://github.com/Keeper-Security/keeper-sdk-javascript/blob/main/.git-blame-ignore-revs so it can be filtered out for git blames

@tylerccarson

Copy link
Copy Markdown
Contributor

Thanks for adding the main.yml check. Caught one more thing-- if you truly want to match the style of keeperapi, you'll need to copy over the .prettierrc: https://github.com/Keeper-Security/keeper-sdk-javascript/blob/main/keeperapi/.prettierrc

As-is, I noticed 2-width tabs and semi-colons, but we use 4-width tabs and no semi colons (looks like we set 5 overrides in total).

@tylerccarson tylerccarson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks for the updates

@sgaddala-ks
sgaddala-ks merged commit 8dcac20 into main Jul 17, 2026
6 checks passed
@sgaddala-ks
sgaddala-ks deleted the keepersdk-format branch July 17, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants