Cancel queued up work on ctrl-c #425#433
Merged
gkreitz merged 1 commit intoJun 17, 2026
Merged
Conversation
Tagl
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the behavior of ctrl-c when running verifyproblem multithreaded. Now, if we're exiting due to a
KeyboardInterrupt, we cancel all queued up futures, preventing new jobs from starting.There is a potential for a race still if a thread starts a new run before we cancel (all running processes will get a SIGINT from the ctrl-c, so running jobs will die). I was completely unable to hit that race, so I kept my PR as simple as possible (Fixing it properly is painful. I originally had a heuristic which did a SIGTERM to all child processes, but removed it to simplify the PR when I saw that it seemed reliable enough without it).
Fixes #425